-
Notifications
You must be signed in to change notification settings - Fork 187
feat(fw,tests): EIP-6110, EIP-7002, EIP-7251, EIP-7702: Pectra Devnet-4 updates #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ee7a97 to
35a8be9
Compare
77b36d1 to
5fd9880
Compare
2f9d2b0 to
de37130
Compare
|
I do not see this PR listed: This might seem like a no-op but this strictly checks that the |
f99fec5 to
34016d2
Compare
f49210a to
f5799c8
Compare
Co-authored-by: Jochem Brouwer <[email protected]>
b7dd3cb to
a7f0eca
Compare
spencer-tb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm happy with this. I've spent a lot of today review it to copy pasta some items for 7742
…-4 updates (ethereum#832) * fix(forks): Update 7002, 7251 contracts * feat(forks): Add 7685 methods * fix(fw): Remove requests from block body, add as parameters for new payload * refactor(tests): Refactor requests usages, add more 7685 tests * feat(tests): EIP-7702, #8929 changes - Incomplete * Update tests/prague/eip7702_set_code_tx/spec.py Co-authored-by: Jochem Brouwer <[email protected]> * feat(exceptions): Add invalid authorization format exception * new(tests): EIP 7702: chain id/nonce overflow tests * new(tests): EIP 7702: delegation clearing test * new(tests): EIP 7702: delegation clearing on failure test * new(tests): EIP 7702: fixup * new(tests): EIP 7702: test deployting a delegation-like contract * fix(tests): EIP 7702: remove `test_set_code_to_zero_address` * new(tests): EIP 7702: add `test_signature_s_out_of_range` * fix(forks): EIP-7002,7251 contracts * new(tests): EIP-7002: withdrawal request during fork * fix(tests): EIP-7002: fixup * fix(tests): EIP-7002: fixup * new(tests): EIP-7251: consolidation requests during fork * fix(tests): tox * github: Add devnet-4 configs * fix(github): feature devnet-4 * fix(tests): EIP-6110 conftest * fix(github): feature * fix(specs): Propagate `block.requests` to the Engine API params * fix(tests): Fix override requests comparison for empty list * fix(tox): whitelist * fix(tests): EIP-7702: note in `test_tx_validity_nonce` * new(tests): EIP-7702: Add invalid `v` (27, 28) for auth tuple test * chore(hive): update hive client config file in test summary * fix(plugins/execute): Requests * fix(rpc): Support `engine_getPayloadV4` * fix(plugins/execute): Support `engine_getPayloadV4` * fix(tests): EIP-7702: test id * fix(tests): EIP-7702: execute marks --------- Co-authored-by: Jochem Brouwer <[email protected]> Co-authored-by: danceratopz <[email protected]>
🗒️ Description
Extra New Tests
Breaking Changes
T8N Interface
resultobject (returned by the transition tool) fieldsdeposit_requests,withdrawal_requestsandconsolidation_requestsare deprecated and substituted by fieldrequestswhich contains a list of hex strings (due to engine: Make execution requests a sidecar, take 2 execution-apis#591), where each element represents the output of the requests contract (requests_data).resultobject fieldrequests_roothas been renamed torequests_hash, and the value of this field needs to be updated to be calculated assha256(sha256(requests_0) ++ sha256(requests_1) ++ ...), whererequests_0 = request_type_0 ++ request_data_0Blockchain Fixtures Changes
blockHeader.requests_rootfield has been renamed torequests_hashin theblockchain_testfixture type.FixtureBlockBaseandFixtureExecutionPayloadfieldsdeposit_requests,withdrawal_requestsandconsolidation_requestsarereplaced by a single fieldremoved.requests, containing a list of hex strings, where each element represents the bytes of a flattened requestFixtureEngineNewPayload.paramswhich represents the flattened requests.🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.