Add test cases with blocks containing several withdrawal requests #4090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, i think these would have caught our issue. |
jtraglia
approved these changes
Jan 21, 2025
wemeetagain
pushed a commit
to ChainSafe/lodestar
that referenced
this pull request
Jan 27, 2025
Run against latest spec, there are a bunch of good new test cases (eg. ethereum/consensus-specs#4090)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered in devnet-5 by @pk910 in discord regarding Lodestar's inability to process a block that contains multiple valid withdrawal requests.
Likely a gap we've missed in the spec test, as the only tests I have seen which generates multiple withdrawal requests are from
random_block_electra()which the requests are not valid.Adding test cases in sanity blocks to cover this scenario. Have tested locally with pre-patched Lodestar failing and post-patched Lodestar passing.