eip7251: Fix partial withdrawals count #3943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
reviewed
Sep 26, 2024
tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_withdrawals.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Traglia <[email protected]>
ralexstokes
approved these changes
Sep 30, 2024
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
nice catch! and I think this is a good fix for now
it may help testing/reasoning to refactor get_expected_withdrawals but that can come later, if it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug found by @terencechain, detailed description can be found in this report: https://hackmd.io/@ttsao/S13TVqkA0
TL;DR:
partial_withdrawals_countwasn’t taking skipped partial withdrawals into account, thus, some partial withdrawals were not removed from the queue even though there were processed which finally resulted in them being included twice into EL blocks.This PR contains a test covering the above case, but there still the need of writing more tests for pending partial withdrawals.
ToDo