-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Moving requests out of execution_payload into beacon_block.body #3875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
355a9a3
Introducing ExecutionPayloadEnvelope
lucassaldanha ed9b061
Comments
lucassaldanha f26c9be
Removing EL requests from ExecutionPayload
lucassaldanha f9ac902
Updated light-client block -> header function
lucassaldanha e26a3e0
New execution payload global index
lucassaldanha 9a2e088
requests_root
lucassaldanha 858402f
Updated with requests on block body
lucassaldanha 794b942
Undo execution_payload gsync change
lucassaldanha 5c88de8
Remove requests in execution_payload from full-node lightclient spec
lucassaldanha 6669675
Test updates
lucassaldanha 4185c00
Fork fix and tests
lucassaldanha fa78e0d
PR comments
lucassaldanha e3ec53f
Fix lint
lucassaldanha 3527a9b
Cleaning unchanged ExecutionPayload
lucassaldanha b84316d
PR Comments
lucassaldanha 98dd188
Rename requests to execution_requests
lucassaldanha dc1892e
Updated NewPayloadRequest
lucassaldanha b8ca7cc
PR comments
lucassaldanha e445cdf
Merge branch 'dev' into 3865
lucassaldanha 38baa57
Rename ExecutionLayerRequests to ExecutionRequests
lucassaldanha 31225f1
Temp fix for linter on eip-7732 beacon chain spec
lucassaldanha abf382a
Fix 7732
potuz beff03d
Updated verify_and_notify_new_payload and notify_new_payload
lucassaldanha c8dd790
Fix linter
lucassaldanha 622ccd1
Updated ElectraSpecBuilder (NoopExecutionEngine#notify_new_payload)
lucassaldanha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,12 +30,14 @@ | |||||
| - [`WithdrawalRequest`](#withdrawalrequest) | ||||||
| - [`ConsolidationRequest`](#consolidationrequest) | ||||||
| - [`PendingConsolidation`](#pendingconsolidation) | ||||||
| - [`ValidatorRequests`](#validatorrequests) | ||||||
| - [`ExecutionPayloadEnvelope`](#executionpayloadenvelope) | ||||||
| - [Modified Containers](#modified-containers) | ||||||
| - [`AttesterSlashing`](#attesterslashing) | ||||||
| - [`BeaconBlockBody`](#beaconblockbody) | ||||||
| - [Extended Containers](#extended-containers) | ||||||
| - [`Attestation`](#attestation) | ||||||
| - [`IndexedAttestation`](#indexedattestation) | ||||||
| - [`BeaconBlockBody`](#beaconblockbody) | ||||||
| - [`ExecutionPayload`](#executionpayload) | ||||||
| - [`ExecutionPayloadHeader`](#executionpayloadheader) | ||||||
| - [`BeaconState`](#beaconstate) | ||||||
|
|
@@ -258,36 +260,35 @@ class PendingConsolidation(Container): | |||||
| target_index: ValidatorIndex | ||||||
| ``` | ||||||
|
|
||||||
| ### Modified Containers | ||||||
| #### `ValidatorRequests` | ||||||
|
|
||||||
| #### `AttesterSlashing` | ||||||
| *Note*: The container is new in EIP????. | ||||||
|
|
||||||
| ```python | ||||||
| class AttesterSlashing(Container): | ||||||
| attestation_1: IndexedAttestation # [Modified in Electra:EIP7549] | ||||||
| attestation_2: IndexedAttestation # [Modified in Electra:EIP7549] | ||||||
| class ValidatorRequests(Container): | ||||||
| deposit_requests: List[DepositRequest, MAX_DEPOSIT_REQUESTS_PER_PAYLOAD] # [New in Electra:EIP6110] | ||||||
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| withdrawal_requests: List[WithdrawalRequest, MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD] # [New in Electra:EIP7002:EIP7251] | ||||||
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| consolidation_requests: List[ConsolidationRequest, MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD] # [New in Electra:EIP7251] | ||||||
| ``` | ||||||
|
|
||||||
| ### Extended Containers | ||||||
| #### `ExecutionPayloadEnvelope` | ||||||
|
|
||||||
| #### `Attestation` | ||||||
| *Note*: The container is new in EIP????. | ||||||
|
|
||||||
| ```python | ||||||
| class Attestation(Container): | ||||||
| aggregation_bits: Bitlist[MAX_VALIDATORS_PER_COMMITTEE * MAX_COMMITTEES_PER_SLOT] # [Modified in Electra:EIP7549] | ||||||
| data: AttestationData | ||||||
| signature: BLSSignature | ||||||
| committee_bits: Bitvector[MAX_COMMITTEES_PER_SLOT] # [New in Electra:EIP7549] | ||||||
| class ExecutionPayloadEnvelope(Container): | ||||||
| execution_payload: ExecutionPayload # [Modified in Electra:EIP6110:EIP7002] | ||||||
| requests: ValidatorRequests | ||||||
| ``` | ||||||
|
|
||||||
| #### `IndexedAttestation` | ||||||
| ### Modified Containers | ||||||
|
|
||||||
| #### `AttesterSlashing` | ||||||
|
|
||||||
| ```python | ||||||
| class IndexedAttestation(Container): | ||||||
| # [Modified in Electra:EIP7549] | ||||||
| attesting_indices: List[ValidatorIndex, MAX_VALIDATORS_PER_COMMITTEE * MAX_COMMITTEES_PER_SLOT] | ||||||
| data: AttestationData | ||||||
| signature: BLSSignature | ||||||
| class AttesterSlashing(Container): | ||||||
| attestation_1: IndexedAttestation # [Modified in Electra:EIP7549] | ||||||
| attestation_2: IndexedAttestation # [Modified in Electra:EIP7549] | ||||||
| ``` | ||||||
|
|
||||||
| #### `BeaconBlockBody` | ||||||
|
|
@@ -305,11 +306,33 @@ class BeaconBlockBody(Container): | |||||
| voluntary_exits: List[SignedVoluntaryExit, MAX_VOLUNTARY_EXITS] | ||||||
| sync_aggregate: SyncAggregate | ||||||
| # Execution | ||||||
| execution_payload: ExecutionPayload # [Modified in Electra:EIP6110:EIP7002] | ||||||
| execution_payload_envelope: ExecutionPayloadEnvelope # [Modified in Electra:EIP????] | ||||||
| bls_to_execution_changes: List[SignedBLSToExecutionChange, MAX_BLS_TO_EXECUTION_CHANGES] | ||||||
| blob_kzg_commitments: List[KZGCommitment, MAX_BLOB_COMMITMENTS_PER_BLOCK] | ||||||
| ``` | ||||||
|
|
||||||
| ### Extended Containers | ||||||
|
|
||||||
| #### `Attestation` | ||||||
|
|
||||||
| ```python | ||||||
| class Attestation(Container): | ||||||
| aggregation_bits: Bitlist[MAX_VALIDATORS_PER_COMMITTEE * MAX_COMMITTEES_PER_SLOT] # [Modified in Electra:EIP7549] | ||||||
| data: AttestationData | ||||||
| signature: BLSSignature | ||||||
| committee_bits: Bitvector[MAX_COMMITTEES_PER_SLOT] # [New in Electra:EIP7549] | ||||||
| ``` | ||||||
|
|
||||||
| #### `IndexedAttestation` | ||||||
|
|
||||||
| ```python | ||||||
| class IndexedAttestation(Container): | ||||||
| # [Modified in Electra:EIP7549] | ||||||
| attesting_indices: List[ValidatorIndex, MAX_VALIDATORS_PER_COMMITTEE * MAX_COMMITTEES_PER_SLOT] | ||||||
| data: AttestationData | ||||||
| signature: BLSSignature | ||||||
| ``` | ||||||
|
|
||||||
| #### `ExecutionPayload` | ||||||
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
|
|
||||||
| ```python | ||||||
|
|
@@ -875,7 +898,7 @@ def process_pending_balance_deposits(state: BeaconState) -> None: | |||||
| if processed_amount + deposit.amount > available_for_processing: | ||||||
| break | ||||||
| # Deposit fits in the churn, process it. Increase balance and consume churn. | ||||||
| else: | ||||||
| else: | ||||||
| increase_balance(state, deposit.index, deposit.amount) | ||||||
| processed_amount += deposit.amount | ||||||
| # Regardless of how the deposit was handled, we move on in the queue. | ||||||
|
|
@@ -946,8 +969,8 @@ def process_effective_balance_updates(state: BeaconState) -> None: | |||||
| ```python | ||||||
| def process_block(state: BeaconState, block: BeaconBlock) -> None: | ||||||
| process_block_header(state, block) | ||||||
| process_withdrawals(state, block.body.execution_payload) # [Modified in Electra:EIP7251] | ||||||
| process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Electra:EIP6110] | ||||||
| process_withdrawals(state, block.body.execution_payload_envelope.execution_payload) # [Modified in Electra:EIP7251:EIP????] | ||||||
| process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Electra:EIP6110:EIP????] | ||||||
|
||||||
| process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Electra:EIP6110:EIP????] | |
| process_execution_payload(state, block.body, EXECUTION_ENGINE) |
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
lucassaldanha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.