Skip to content

Conversation

@rjl493456442
Copy link
Member

No description provided.

@tjayrush
Copy link

tjayrush commented Aug 28, 2017

Simply for the sake of accuracy, in your EIP, you say

Before the metropolis, user determines the status of the transaction by checking whether the transaction gas has been all consumed.

This is actually not correct. Checking if all the gas was consumed is not adequate to determine if a transaction succeeded or not. There are cases where a transaction uses exactly as much gas as was provided and does not fail. I don't have solid numbers, but I did a test a while ago that showed that more than half of transactions with gasAllowed==gasUsed did not end in error. A very, very large percentage of those were simple transfers of value with gasAllowed == 21000. There were many that were contract executions were gasAllowed == gasUsed that also did not end in error.

I agree with your point--the result of the execution should be (and always should have been) in the receipt--but I do think it's important to be accurate in these EIPs.

Furthermore, I think there's already an EIP for this, but I'm not sure it's the same: #658.

@rjl493456442
Copy link
Member Author

I'm so sorry for my mistake and i have modified the inaccurate part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants