-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Update EIP-4844: Decouple blobs #6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3bc1d36
Update EIP-4844: Decouple blobs
g11tech 7d87825
apply feedback
g11tech 8841f61
update the proof function to public one
g11tech 55609d2
explicity verify proofs number to match commitment and versioned hashes
g11tech d9517d7
rename blob_proofs to more succinct proofs for network wrapper
g11tech 656cb21
Replace kzgs references with a more generalized term: commitments
g11tech 0132e81
removing redundant blob prefix from versioned hashes in BlobTransacti…
g11tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest renaming all
BLOB_COMMITMENT_VERSION_KZGtoVERSIONED_HASH_VERSION_KZGas CL specs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm ...
BLOB_COMMITMENT_VERSION_KZGmakes more sense to me as its the version of the commitment schemeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the rationale was the version of
VersionedHash. I'm not sure what's the scenario of changingVERSIONED_HASH_VERSION_*but not just changing the commitment scheme though.It should be unified to one of the names anyway.
/cc @asn-d6 @dankrad any thoughts?
And
kzg_to_versioned_hashwas also renamed tokzg_commitment_to_versioned_hash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion here. I think both variants are reasonable.
I would go with @hwwhww suggestions to make it the same with consensus-specs.