Skip to content

Update EIP-5656: resolve gas calculation inconsistency in EIP-5656 #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update EIP-5656: resolve gas calculation inconsistency in EIP-5656 #10604

wants to merge 1 commit into from
+3 −3

Conversation

@hawkadrian
Copy link
Contributor

Fixes conflicting gas cost formulas in MCOPY specification:

  • First formula included memory_expansion_cost
  • Second formula excluded memory_expansion_cost

This inconsistency could lead to incorrect implementations where memory expansion costs are not properly accounted for.

@hawkadrian hawkadrian requested a review from eth-bot as a code owner October 24, 2025 16:55
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Oct 24, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 24, 2025 •
edited
Loading

File EIPS/eip-5656.md

Requires 1 more reviewers from @axic, @cdetrio, @charles-cooper, @chfast, @jwasinger, @poemm
Requires 2 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Oct 24, 2025
@eth-bot eth-bot changed the title fix: resolve gas calculation inconsistency in EIP-5656 Update EIP-5656: resolve gas calculation inconsistency in EIP-5656 Oct 24, 2025
g11tech
g11tech reviewed Oct 25, 2025
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a technical change in the EIP, needs author approvals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g11tech g11tech g11tech left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hawkadrian @eth-bot @g11tech