Skip to content

Conversation

@smartcontracts
Copy link
Contributor

Description
Pulls the getSentMessages function out of the MessageRelayer and adds some unit tests. Also adds some additional validation checks to each function to improve our error observability.

@smartcontracts smartcontracts requested a review from K-Ho as a code owner May 18, 2021 19:51
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2021

🦋 Changeset detected

Latest commit: 28a84f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #903 (3e58200) into develop (9fea7c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #903   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fea7c9...3e58200. Read the comment docs.

@smartcontracts smartcontracts requested a review from tynes May 18, 2021 23:22
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the txhash in the error message?

@smartcontracts smartcontracts force-pushed the kelvin/relayer-improvements-1 branch from 2145c8e to 28a84f2 Compare May 25, 2021 01:40
@smartcontracts smartcontracts marked this pull request as draft May 25, 2021 23:34
@tynes
Copy link
Contributor

tynes commented May 26, 2021

@smartcontracts What is the status of this PR? I notice that its no longer ready for review

@smartcontracts
Copy link
Contributor Author

@smartcontracts What is the status of this PR? I notice that its no longer ready for review

I'm gonna close this PR since it's largely superseded by #952

@smartcontracts smartcontracts deleted the kelvin/relayer-improvements-1 branch May 26, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants