-
Notifications
You must be signed in to change notification settings - Fork 3.8k
maintenance[message-relayer]: make getSentMessages function more testable #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 28a84f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #903 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
tynes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include the txhash in the error message?
2145c8e to
28a84f2
Compare
|
@smartcontracts What is the status of this PR? I notice that its no longer ready for review |
I'm gonna close this PR since it's largely superseded by #952 |
Description
Pulls the
getSentMessagesfunction out of theMessageRelayerand adds some unit tests. Also adds some additional validation checks to each function to improve our error observability.