feat: add default metrics tracking to batch-submitter #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieke
requested review from
ben-chain,
karlfloersch and
smartcontracts
as code owners
🦋 Changeset detectedLatest commit: 6d6c722 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
snario
approved these changes
Apr 22, 2021
annieke
force-pushed
the
feat/bs-metrics
branch
from
e1f21c3 to
4d2a1c9
Compare
annieke
force-pushed
the
feat/bs-metrics
branch
from
4d2a1c9 to
6d6c722
Compare
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* export metrics in core-utils * initialize metrics in batch submitters * add changeset * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
Metricsto each batch submitter, which enables us to start collecting metrics. It does not yet start to track specific metrics (which will be implemented in followup PRs when our prom server is running).Additional context
Here is the list of default metrics being collected:
https://github.com/siimon/prom-client/blob/96f7495d66b1a21755f745b1367d3e530668a957/lib/defaultMetrics.js#L5-L17