Skip to content

Conversation

@aliersh
Copy link
Contributor

@aliersh aliersh commented Sep 17, 2025

Summary

Refactors the test validation script to externalize exclusion logic into a TOML config file, and adds full test coverage for validation functions.

This change improves maintainability and flexibility:

  • Exclusions can now be updated via configuration, without touching Go code

  • The TOML file serves as a single source of truth shared between the current Go-based validation and upcoming Python tooling for the AI Test Maintenance system

  • This reduces duplication and risk of inconsistency, while making it easier to evolve both implementations in parallel

    Changes Made

    Core Refactor

    • Extracted exclusions to TOML: Moved all exclusion lists from inline Go arrays to exclusions.toml
    • Added TOML loading: Implemented loadExclusions() function with proper error handling
    • Maintained backward compatibility: All existing validation logic remains unchanged

    Test Coverage

    • Complete function coverage: Added tests for all main validation functions

    Files Modified

    • packages/contracts-bedrock/scripts/checks/test-validation/main.go - Core refactor to use TOML
    • packages/contracts-bedrock/scripts/checks/test-validation/main_test.go - Added test suite
    • packages/contracts-bedrock/scripts/checks/test-validation/exclusions.toml - New config file

- move hardcoded exclusion lists from Go code to external TOML configuration
- add TOML parsing with structured ExclusionsConfig type
- implement dynamic exclusions loading with fallback path resolution
- add tests for all previously untested functions in main.go
- organize test functions to match source file order
@aliersh aliersh requested a review from a team as a code owner September 17, 2025 19:19
@aliersh aliersh requested a review from mbaxter September 17, 2025 19:19
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.83%. Comparing base (2503148) to head (df27dc1).
⚠️ Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17510       +/-   ##
============================================
+ Coverage    81.75%   95.83%   +14.08%     
============================================
  Files          167      112       -55     
  Lines         9880     5095     -4785     
============================================
- Hits          8077     4883     -3194     
+ Misses        1657      212     -1445     
+ Partials       146        0      -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 95.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mds1 mds1 enabled auto-merge September 21, 2025 13:16
@mds1 mds1 added this pull request to the merge queue Sep 21, 2025
Merged via the queue into develop with commit 565ec51 Sep 21, 2025
67 checks passed
@mds1 mds1 deleted the ari/tests-validation-exclusions-file branch September 21, 2025 13:35
BrycePy added a commit to gattaca-com/based-optimism that referenced this pull request Nov 13, 2025
* op-service/eth: fix exec payload creation from block (#17154)

* op-service/eth: fix validationError string pointer reference

* op-service/eth: fix exec payload creation from block

Execution payloads must only set the withdrawals root post-Isthmus.
The block's withdrawals root is set during assembly pre-Isthmus.

* go: update op-geth dependency

* op-node: remove PromoteFinalizedEvent (#17165)

* chore(op-acceptance-tests): migrate TestInteropReadiness to op-devstack (#17160)

Convert the TestInteropReadiness test from devnet-sdk to op-devstack framework.
Use MultiCaller batching for contract interactions and presets.NewSimpleInterop()
for test setup. Fix challenger preset compilation issue temporarily.

* ci: Increase timeout of publish-cannon-prestates job (#17163)

* op-e2e: Remove unused withdrawal action methods (#17128)

* Remove unused withdrawal action methods

* fix lint from ‘go fmt’ to make ci happy

* feat(devstack/rpc): expose rpc endpoint (#17168)

* op-deployer: Add forge autodiscovery (#17152)

* op-deployer: Add forge autodiscovery

* add limit reader

* cr updates

* op-acceptance-tests: Introduce GameHelper to perform multiple moves (#16994)

* op-acceptance-tests: Add helper contract to perform multiple moves in dispute games.

# Conflicts:
#	op-acceptance-tests/tests/isthmus/operator_fee/tx_utils.go

* op-acceptance-tests: Rename GameState to GameHelper and use it via FaultDisputeGame rather than directly.

* op-acceptance-tests: Verify claims are responded to correctly

# Conflicts:
#	op-devstack/dsl/proofs/fault_dispute_game.go

* op-acceptance-tests: Better test name

* op-acceptance-tests: Simplify

* Use specific imports.

* Fix contract checks.

* Add comment

* Update snapshots.

* Remove unused extraData

* Remove unused extraData

* op-acceptance-tests: Review feedback

* plan: Add test that other node's dependencies are unaffected.

* plan: Introduce single function to reset fn and dependencies.

* dsl: Don't set a fixed gas limit for ETH transfers.

Transferring ETH to a contract uses more than 21,000 gas.

* op-service: Clarify testlogs (#17174)

* cannon: Drop version 7 feature flags (#17167)

* Drop SupportMinimalSysEventFd2 feature flag

* Drop SupportDclzDclo feature flag

* Drop SupportNoopMprotect feature flag

* Bump MIPS64 contract version

* Fix typo

* Cut unused variable

* Run semver-lock

* Update mips version in the StandardValidator

* Run semver-lock

* Bump StandardValidator contract version

* Cut unused features / stateVersion variables

* op-program: Disable go1.25 annotation of anonymous memory mappings. (#17176)

Prepares for go 1.25 to avoid it needing the prctl syscall which cannon doesn't support.

* acceptance-tests: Wait for follower node to be in sync with sequencer before allowing tests to start using the system. (#17179)

* feat: create a v2 of the fault dispute game to validate creator pattern (#16929)

* feat: create a new version of the fault dispute game to validate creator pattern flow

* chore: make ci happy with interface

* chore: run pre pr snapshots and rename interface to fix ci

* chore: remove duplicated(?) files

* chore: update immutable variable allowlist

* fix: exclude the FaultDisputeGameV2 from reinitialize test

* fix: array access

* fix: compiler setting restriction v2

* fix: snapshot lock

* fix: add faultdisputegame v2 to allowlist

* fix: use correct path

* feat: add helper function to test contract for v2 fdg

* Update packages/contracts-bedrock/test/dispute/DisputeGameFactory.t.sol

Co-authored-by: mbaxter <[email protected]>

* fix: remove CANNON_2 for now

* fix: pull in readability change for cwia

* fix: add error to interface

* fix: add error to interface

* chore: bump semver and lock

---------

Co-authored-by: mbaxter <[email protected]>

* Move `closer.Close()` to a defer statement immediately after error checking (#17166)

* op-sync-tester: Verifier Engine APIs for Isthmus (#17072)

* op-sync-tester: Verifier Engine APIs

* refactor and add comments

* rebasing for changing canyon from shanghai

* op-sync-tester: Verifier Engine APIs for Ecotone, Fjord, Granite, Holocene (#17181)

* Support fjord, granite, holocene

* Revise comments

* op-devstack: add SyncTester to sysgo; initial E2E test with SyncTester (#17132)

* op-devstack: link SyncTester with L2CL; initial e2e test

* op-sync-tester: augment sync tester config

* op-devstack: add TargetBlocks to sync tester initialization

* op-sync-tester, op-devstack: use FCUState

* op-devstack: remove SyncTester.hydrate

* op-acceptance-tests: enable L2CL2 sync with SyncTester

* op-sync-tester, op-devstack: renames

* op-devstack: remove pointer as FCUState is mandatory

* Upload finalized Cannon (Go 1.24) audit report (#17183)

* feat(cannon): reduce info logging frequency from %100000 to %1000000 (#17186)

* optimize cannon ux

* Fix from %1000000 to %1000000000

* Update README.md (#16753)

* Reorganize sync deriver logic (#17098)

* op-devstack: add hydrate to sync tester (#17198)

* cannon: Deploy Cannon with Go 1.24 support (#17155)

* Update standard MIPSVersion constant

* Update OPCMStandardValidator stateVersion() check

* Update StandardConstants.MIPS_VERSION

* Replace hard-coded mipsversion values in OPCMStandardValidator tests

* Run forge fmt

* Update OPContractsManagerStandardValidator version

* Run semver-lock

* chore: Add fork retries to upgrade tests (#17201)

* chore: Add fork retries to upgrade tests

* fix: Param

* chore: Use env instead

* feat(kurtosis-devnet): 1/2 add flashblocks support (#17172)

* feat(kurtosis-devnet): flashblocks support

* feat(kurtosis-devnet): lint

* fix(flashblocks): 1/2 comments

* all: Update op-geth dependency, based on geth v1.16.1 (#16785)

* Upgrade op-geth with upstream v1.16.1 version

* Update to fix linters

* go mod tidy

* Fix part of tests

* Update op-geth dependency

* don't enable osaka in op-program test miner

* Bump op-geth version

* Disable Osaka in op-program test miner

* op-program: Refresh cannon compat report (#17071)

This is done for an incoming op-geth dependency update.
The new vm-compat findings highlight a new control flow path where the
flock syscall could be used. Similar control flow paths already exist in
the existing compatibility report. And these are benign for the same
reason; because they're only reachable by a program that uses a real
file-based ethdb.Database. The op-program uses a memory-based
ethdb.Database implementation to ensure that no file-related operations
occur during its execution.

The other flagged (WARNING) syscall use is related to the above flock
operation. This occurs when the go runtime issues epoll_ctl syscalls to
synchronize the file lock. Since we know that file operations won't
occur, this syscall use is also unreachable.

* Bump op-geth version

* op-service/eth: fix validationError string pointer reference

* op-service/eth: fix exec payload creation from block

Execution payloads must only set the withdrawals root post-Isthmus.
The block's withdrawals root is set during assembly pre-Isthmus.

* Bump op-geth version

* Bump op-geth version (catch nil chainView)

* Bump op-geth dependency to v1.101601.0-rc.1

---------

Co-authored-by: Sebastian Stammler <[email protected]>
Co-authored-by: Inphi <[email protected]>

* challenger: Add a metric to report the number of consecutive failures (#17193)

* challenger: Add a metric to report the number of consecutive failures per VM type

Allows ignoring transient errors in setup because a source node is briefly offline.

* challenger: Create vmInstructionCacheMissCount metric.

Fixes nil dereference.

* superchain-config: Fix fuzz test proxyAdmin constraints (#17203)

* Disallow *super* proxyAdmin/Owner

* Tweak comment

* op-up: add ascii art (#17205)

* op-chain-ops: update srcmap loading to handle forge compiler profiles (#17196)

* op-up: add survey link (#17206)

* op-up: add ascii art

* op-up: add survey link

We needed to build the orchestrator ourselves instead of using
the higher-level `presets.DoMain` function because `DoMain` calls
`os.Exit`, preventing us from showing the link on exit. This
dependency was also preventing us from implementing better CLI
handling (#17076), which is now unblocked.

* op-up: basic cli argument handling (#17208)

* ci: Write cannon preimage commit info to a temp file before uploading (#17219)

May let gsutil cp retry better and fix flakiness.

* op-sync-tester: implement L2ELNode interface with sync tester (#17200)

* op-devstack: implement SyncTester as ELNode interface

* op-sync-tester: remove Target and EntryCfg

* op-devstack: use ids.SyncTester identity for the SyncTester

* op-devstack: both userRPC and authRPC contain session parameters

* op-devstack: add user and auth proxy to sync tester

* chore: update op-deployer docs (#17204)

* Update installation.md

* Update installation.md

* fix(ci): remove #986 todo (#17229)

* Verify contract deployment tx is actually included. (#17232)

The generated bindings only verify that the transaction can be sent, not that it was actually included which can lead to race conditions where estimating gas for the next tx that uses the transaction fails because there is no code at the address if the tx is still pending.

* op-sync-tester: Verifier Engine APIs for Bedrock, Canyon, Delta (#17234)

* op-sync-tester: Verifier Engine APIs for Bedrock, Canyon, Delta

* op-devstack: Presets for sequential HF activation

* op-acceptance-tests: L2CL with Sync Tester advance HF with distinct time

* typo

* feat(op-devstack): support kona supervisor sysgo (#17195)

* feat(op-devstack): support kona-supervisor in sysgo

* remove cluster rollupcfg

* supervisor opt removed

* op-up: add unit test (#17210)

* op-program: Fix length check for pending progress in consolidate step (#17220)

* op-challenger: Implement an option to restrict frequency of update cycles. (#17233)

By running update cycles less often, the number of calls made to the L1 node can be reduced.

* feat(op-acceptance-tests): flaky test report; updates. (#17250)

- Ensure its sorted by #flakes(desc)
- Add a warning about positive false positives

* op-sync-tester: Session Types and API interfaces (#17252)

* op-sync-tester: Session Types and API interfaces

* linter

* op-deployer: Add forge CLI wrapper (#17231)

* op-deployer: StandardBin enforces specific forge version (#17242)

* AutodetectBin enforces specific forge version

* remove dir creation from AutodetectBin.Ensure()

* rename AutodetectBinary to StandardBinary

* cannon: Reduce size of heap/code cache (#17246)

* cannon: Reduce size of heap/code cache

* op-e2e: Bump executor limiter for fp tests

* cannon: rename defaultCodeRegionSize

* op-devstack: Fix flakiness in AwaitTimestamp (#17270)

There's no guarantee that a waiter will see every block, so just find the block the fork should activate and wait for it specifically.

* op-deployer: enable embedded artifacts integration test (#17276)

* ci: Remove codecov from go tests (#17291)

* op-devstack: Explicit Sync Tester EL and API Session Binding  (#17275)

* op-devstack: Explicit mock EL and Session binding

* Add dummy session to acceptance tests

* op-devstack: better sync tester naming and init

* revoke and comments

* Modularize and clean up

* configurable delay between game responses (#16988)

* update op-challenger README devnet startup commands

* implement basic version of configurable delay between game responses inside the op-challenger

* add integration testing for the ResponseDelay parameter which controls the configurable delay between game responses

* implement feedback from reviews, in particular improvements to the unit / integration testing and switching to use of clock.Clock

* implement ResponseDelayAfter config, adding a new config param controlling how many responses into each game the ResponseDelay config should become active

* implement the agent to respond immediately (bypass any ResponseDelay config set) if the game is currently inside the extension period

* make improvements from feedback, add a check to ensure that delaying only occurs when it will not cause the challenger to wait until the extension period begins, and also add the additionally needed testing associated with that new check

* fix minimal race condition of responseCount using mutex

* simplify delay calculation logic by removing calculateActualExtension() function and its associated testing, since the base extension is, anyway, a more conservative figure

* switch to using an atomic int for responseCount instead of a separate mutex

* add clarity on the functioning of the ResponseDelay and ResponseDelayAfter configuration fields in config.go

* Apply suggestions from code review

Co-authored-by: Adrian Sutton <[email protected]>

* correct bug identified in feedback with wrong grandparent claim logic in agent.go and updated relevant tests

* fix typo from suggestion and associated issues in testing

* simplify logical legibility based on review feedback in agent.go

---------

Co-authored-by: Adrian Sutton <[email protected]>

* chore: remove the frozen file check (#17289)

* chore: remove the frozen file check

* fix: remove references to removed script

* fix: remove frozen code check

* feat(op-acceptance-tests): port fjord (holocene) tests to devstack (#16920)

* feat(op-acceptance-tests): port fjord (holocene) tests to devstack

* feat(op-acceptance-tests): add holocene to base tests

* cr nits

* block nos

* blocknum

* fix(tests): fix port

* fix(tests): typo

* fix(op-acceptance-tests): typo

* fix(op-acceptance-tests): simplify tests

* fix(op-acceptance-tests): fix teku version

* fix(op-acceptance-tests): pass context

* fix(op-acceptance-tests): pin l1 block reads

---------

Co-authored-by: Matthew Slipper <[email protected]>

* op-sync-tester: Support sync namespace (#17299)

* op-sync-tester: Sync namespace implementation

* op-devstack: Sync Tester DSL

* op-acceptance-tests: Sync Tester sync namespace tests

* all: Update op-geth dependency, based on geth v1.16.2 (#17228)

* update op-geth version

* Update cannon baseline files for geth 1.16.2 upgrade.

---------

Co-authored-by: Adrian Sutton <[email protected]>

* op-deployer: add configurable chainIntent.GasLimit field (#17271)

* feat(op-acceptance-tests): Port TestSmokeTestFailure and TestInteropSystemNoop to Devstack (#17300)

* feat(op-acceptance-tests): port interop smoke tests

* feat(op-acceptance-tests): linter

* ci: Run the publish-cannon-prestates job on circleci boxes instead of latitude. (#17296)

It doesn't need lots of resources and we're seeing network flakiness so try uploading from a different network.

* op-devstack: add sync-tester with external EL (#17251)

* op-devstack: add sync-tester with ext cl config

* op-devstack: try setting up remote L2 chain

* op-devstack: use remote EL and CL for L1 nodes

* op-devstack: fix L2CL from sequencer to verifier

* op-devstack: remove redundant configs

* op-acceptance-tests: use RPC for CI

* op-acceptance-tests: skip tests until CI allows tests using external endpoints

* circleci: attempt CI endpoints

* op-devstack: address comments from PR

* op-devstack: address comments from PR

* fix comment for l1.cache-size (#17107)

* feat: add feature flagging functionality to SystemConfig (#17281)

* feat: add feature flagging functionality to SystemConfig

Adds a function to the SystemConfig for feature flagging. Features
are identified by 32 byte strings and can be toggled on or off by
the ProxyAdmin or the owner of the ProxyAdmin. Note that this
commit does not actually use any feature flags but demonstrates
what a feature flag would look like by adding in the flag for
the ETHLockbox feature.

* feat: update for PR feedback

* fix: small test tweaks

* fix: broken test

* feat(op-acceptance-tests): add more sysgo tests. (#16817)

* feat(op-acceptance-tests): add more sysgo tests.

* fix(op-devstack): ecotone; fees.

Use the actual increase in the L1FeeVault balance. This is because in Ecotone, the L1 fee includes both base fee and blob base fee components.

* fix(op-acceptance-tests): skipping flaky/broken tests.

* fix(op-acceptance-tests): interop; TestInteropSystemSupervisor

* fix(op-acceptance-tests): justfile; exit early for gateless.

* fix(op-acceptance-tests): tidied justfile

* fix(op-acceptance-tests): fix ecotone fees.

The recent commit changed L1 fee calculation to use vault balance increases as the source of truth, but base fee and priority fee calculations were still using the old method (calculating from block data). Made all fee calculations by making vault increases the source of truth.

* fix(op-acceptance-tests): increase default timeout for gateless mode.

* chore: Conditional logic

* fix(op-acceptance-tests): TestSuperRootWithdrawal nonce issue and timeouts

* fix(op-acceptance-tests): re-enable safeheaddb tests after #17083 fix

* fix(op-acceptance-tests): security; env var injection

The LOG_LEVEL environment variable is used directly in shell command execution without validation or sanitization, allowing command injection attacks.

* feat(op-acceptance-tests): justfile; allow gateless for sysext.

Allow gateless mode to run for an external devnet ('sysext' orchestrator)

* clean(op-acceptance-tests): circleci; removed memory-base job

The new memory-all is a superset of memory-base; so we don't need both.

* fix(op-devstack): enhance Ecotone fee validation and enforce operator vault constraints

  - Add validation that receipt L1Fee matches L1FeeVault increase
  - Restore receipt-based fee calculations for validation (baseFee and L2Fee)
  - Enforce OperatorVault must be zero in Ecotone (operator fees introduced in Isthmus)
  - Exclude OperatorVault from total fee calculations in Ecotone
  - Add comprehensive receipt fee validation checks

* fix(op-devstack): ecotone; cross-validation of fees

Added cross-validation between receipt and vault fees: The code now verifies that:
    - receiptBaseFee (block.BaseFee × gasUsed) equals vaultBaseFee (BaseFeeVault increase)
    - receiptL2Fee (effectiveGasPrice × gasUsed) equals vaultL2Fee (BaseFee + SequencerFee vault increases)

* fix(op-devstack): supervisor sync status L1 mismatch retry

Increase retry attempts and handle L1 sync mismatch errors to fix flaky TestExecMsgDifferEventIndexInSingleTx.

* fix(op-acceptance-tests): TestPostInteropUpgradeComprehensive

Made it serial due to flakiness.

* feat(op-acceptance-tests): ci; tweak timeout and verbosity.

* fix(op-acceptance-tests): exclude interop tests from ci tag

These in-memory devstack tests don't work reliably with gotestsum's
retry mechanism. They run fine via op-acceptor in the memory-all job
but fail when run directly with go test in go-tests-short.

Adding !ci build constraint to exclude from standard CI test suite
while keeping them available for dedicated acceptance test runs.

* fix(op-acceptance-tests): TestWithdrawal nonce synchronization

Use fresh EOA instance for withdrawal initiation to prevent nonce
conflicts when shared L1/L2 keys encounter retry logic.

* chore(op-acceptance-tests): TestPreNoInbox marked as flaky

* chore(op-acceptance-tests): test limiting concurrency

* chore(op-acceptance-tests): self-hosted runner

Default to using our self-hosted runners.
Accept a parameter which allows individual jobs to opt-out and use CCI/Cloud runners.

---------

Co-authored-by: Jan Nanista <[email protected]>

* feat(op-acceptance-tests): move all ATs to one workflow (#16755)

Stop running (sysgo/in-memory) acceptance tests as unit tests in other workflows

* feat(op-acceptance-tests): op-acceptor v3.1.0 (#17310)

Upgrades op-acceptor to [v3.1.0](https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.1.0)

* make `IDelayedWETH` inherit `IProxyAdminOwnedBase` (#16912)

* make IDelayedWETH inherit IProxyAdminOwnedBase

* forge fmt

* circleci, op-acceptance-tests: nightly ci sync tests with external networks (#17314)

* circleci, op-acceptance-tests: nightly ci sync tests with external networks

* circleci: try sync_tester_ext_el within op-acceptance-tests

* circleci: disable test on every push; run on daily schedule

* feat: bump op-geth and update GetCommittedState to GetStateAndCommitedState (#17323)

Co-authored-by: Jacob Elias <[email protected]>

* remove un-used code in backend.FromConfig (#17321)

* remove dup (#17325)

* feat: creator pattern integrate FaultDisputeGameV2 into DGF (#17119)

* feat: update dispute game factory to support impl args

* test: test cwia update through dgf

* fix: test function name linting

* fix: remove unneeded function

* test: move creator pattern create test to create contract

* fix: remove funciton for setImplementationArgs from the interface as well

* fix: add back unclassified tests

* fix(nit): update wording

Co-authored-by: mbaxter <[email protected]>

* fix: conflict from cherry pick

* fix: update table to not be prescriptive about layout

* fix: formatting for table

* test: add tests for v2 and adjust based on impl updates for cwia

* fix: vm getter in tests

* fix: reuse _setGame and add additional param for implArgs

* chore: run forge fmt

* fix: directory structure validation

* fix: semver version bump fault dispute game v2

* fix: add same exclusion that exists for FaultDisputeGame.sol

* fix: bump snapshots

* chore: bump opcm standard validator semver

* fix: assert revert explicitly revert with no data

* fix: fork tests root claim

* fix: remove unused params from _getGameConstructorParamsv2 and setupFaultDisputeGameV2

* fix: bump major version for breaking change

* test: add tests for setImplementation with args

* test: check the rest of the constructor args

* test: set l2ChainId to nonzero value to make validate setting

* chore: remove console.log

* fix: revert earlier with calldata length check

* test: add asserts for the creator and l2blocknumber

* chore: remove comment about skipping in fork environment

* fix: follow new naming convention

* fix: use more realistic args for implArgs

* fix: bump semver for standard validator

* chore: bump snapshot for StandardValidator

---------

Co-authored-by: mbaxter <[email protected]>

* op-sync-tester: Better Session Handling (#17316)

* op-sync-tester: Better Session Handling

* Use lock instead of rlock

* bug fix and style

* handle concurrency properly

* Simply session locking model

* feat: op-node sync tests for multiple networks in ci (#17334)

* feat: try to run synctest inci

* fea: try to run  sync test with envvars

* fea: try to run  sync test with envars and updated job

* fea: try to run  sync test with matrix

* feat: no beacon l1 ci endpoint yet, just add base sepolia

* feat: added some todos for sync tester and unisepolia syncing

* op-acceptance-tests: remove chain id comparison; move runtime logs to test

* do not trigger on PRs

---------

Co-authored-by: Jacob Elias <[email protected]>
Co-authored-by: Anton Evangelatov <[email protected]>

* min-base-fee: bring in op-geth code (#17307)

* boilerplate for Jovian fork

* update op-geth version

brings in min-base-fee code

* changes to get current tests passing

* kurtosis devnet: use temporary image for op-geth

Matches the version currently in go.mod. Can be reverted to default once the op-geth release is made.

We need to do this because interop implies jovian, so we need a jovian compatible op-geth to run with the longer extradata from genesis.

* bump op-geth

* update expected error message in TestCheckEIP1559ParamsMatch

* update to take account of PayloadAttributes.MinBaseFee being a *uint64

* op-program fixes

* fix computePayloadId

* use static error

* update op-geth image for interop kt-devnet

* createGenesisWithForkTime => createGenesisWithForkTimeOffset

* fully add interop override flag to op-service

* refactor: define holoceneArgs in terms of jovianArgs

* add test cases

* MinBaseFeeExtraData -> JovianExtraData

* bump op-geth version, make use of eip1559.DecodeOptimismExtraData

* checkEIP1559ParamsMatch -> checkExtraDataParamsMatch

* bump op-geth

* go mod tidy

* use eip1559.Validate/DecodeOptimismExtraData in PayloadToSystemConfig

* bring interop devnet op-geth in line with go.mod op-geth

* fix bug (pointer comparison)

* fix test

* go mod tidy

* tag issue in TODO

* consolidate: validate extra data even pre Holocene and fix test

* fix test miner to set minbasefee correctly

* use eip1559.DecodeOptimismExtraData in blockToDepositsOnlyAttributes

* bump op-geth

* go mod tidy

* bump op-geth in kt devnet

* only validate extra data from holocene

* bump op-geth to tagged RC

* use pre-Jovian value in test miner.Fork

* op-program test miner: set min base fee to a stub (valid) value if Jovian is active

* remove redundant check on isOptimism

We are always running op rules inside the program

* Co-authorship credit

This PR contains work that was cherry-picked from https://github.com/ethereum-optimism/optimism/pull/16852.
This commit will mean they are credited with co-authorship.

Co-authored-by: William Law <[email protected]>
Co-authored-by: Niran Babalola <[email protected]>

---------

Co-authored-by: William Law <[email protected]>
Co-authored-by: Niran Babalola <[email protected]>

* feat: dev feature flagging in OPCM (#17268)

* feat: dev feature flagging in OPCM

Adds functionality to tests and OPCM that makes it possible to
execute use feature flags in the OPCM that selectively utilize
specific functionality. This flag is represented as a 32 byte
bitmap for op-deployer compatibility and makes it possible to
support 32 unique development features at the same time.

* feat: small ergonomic cleanup

* feat: test fixes

* fix: portal upgrade implementation

* fix: more test fixes

* fix: working on lockbox tests

* fix: most contract tests should work now

* fix: run opcm against latest blocks

* fix: update OPCM bindings

* fix: correct error format in OPCMCC

* fix: update ReadImplementationAddresses

* fix: bug in ReadImplementations

* fix: tweaked superchain config check in ocpm for now

* fix: opcm fix after rebase

* fix: use fake feature for SystemConfig tests

* feat: parameterized tests for dev features

* fix: circle ci syntax

* fix: matrix naming

* feat: parameterize upgrades too

* fix: only parameterize coverage

* feat: more tests

* fix: rebase conflicts

* feat: add dev feature bitmap to e2e

* fix: go bug

* fix: more go test failures

* fix: pr comments

* fix: better check for use super roots

* fix: pr feedback

* fix: skip test for interop lockbox

* fix: typo

* fix: rebase fixes

* fix: ci naming

* feat: updated system config pause (#17322)

* feat: updated system config pause

* fix: ci fixes

* fix: simpler logic in system config paused check

* fix: rebase fixes

* feat: have VerifyOPCM check for dev bitmap (#17324)

* feat: have VerifyOPCM check for dev bitmap

* fix: include required getter in verifyopcm

* op-e2e: Fix broken jovian precompile FP tests (#17349)

* contracts: Add CANNON_KONA game type (#17358)

* contracts: Add CANNON_KONA game type

* contracts: Add SUPER_ASTERISC_KONA game type

* contracts: Add super cannon kona game type

* feat(readme): update directory structure (#17359)

* refactor(op-e2e): use ActivateForkAtOffset utility (#17362)

Currently, each time we do a new fork we need to go back and modify activation action tests for some prior forks. With this change, such modifications will no longer be necessary.

* fix superchainConfig upgrade issue & support multiple superchainConfigs (#16838)

* fix superchainConfig upgrade issue & support multiple superchainConfigs

* fixes to upgrade tests and contracts-check

* better approach, compare versions

* fixes

* fixes

* fix non op upgrade tests

* fix the opcm upgrade checks to support upgradeSuperchainConfig function checks

* add test for SuperchainConfigInconsistent error

* fix upgrade fn superchainConfig check

* add more tests for SemverComp

* implement decisions from design doc review

* implement decisions from design doc review

* fix semver and snapshots

* implement checks for upgradeSuperchainConfig

* fix ci

* address comments

* address comments

* rm dup comment

* improve test nit

* address graphite comments

* fix ci

* op-sync-tester: Better logging (#17364)

* proofs: Introduce PermissionedDisputeGame v2 (#17290)

* Create PDG v2

* Add PDG v2 interface

* Fix references to FDG and interface

* Add PDG v2 test

* Fix pdg v2 setup in test

* Fix pdg v2 game setup in tests

* Add a few more test assertions, rework l2ChainId handling

* Update PDG v2 version

* Update some config files that should reference PDG v2

* Run semver-lock

* fix: exclude PermissionedDisputeGamev2

* chore: run forge fmt

* fix: follow new naming convention

* fix: incoming change added exclusion as well

---------

Co-authored-by: steven <[email protected]>

* docs(op-e2e/system): add deprecation notice (#17369)

* op-e2e/system: add deprecation notice

* clarify where to put acceptance tests

* op-service: cliutils add support for common.Hash (#17376)

* op-service: cliutils add support for common.Hash

* add hash validation to avoid unexpected behavior

* op-challenger: Fix metric label name for asterisc-kona (#17367)

* prestate-check: Add support for kona (#17355)

* prestate-check: Introduce abstraction for how prestate data is loaded

Begins preparing for adding kona prestate support.

* prestate-check: Abstract chain config loader.

op-reth doesn't use the same format for superchain config data.

* prestate-check: Support loading config data for kona states.

* prestate-check: Remove config loader abstraction again.

* prestate-check: Replace todo with explanation

* prestate-check: Point back to optimism branch

* op-program: Use prestate build script in repro.justfile (#17372)

* op-challenger: Add cannon-kona trace support (#17356)

* add kona cannon executor

* implement cannon-kona trace type support

- add TraceTypeCannonKona case to runner/factory.go
- add TraceTypeCannonKona validation to flags/flags.go
- fix CLI arguments for kona-host in kona_server_executor.go

* simplify switch logic over trace types in flags.go

* fix cannon-kona trace type CI failures: add missing validation, test setup, and parameter fixes

* implement more robust Cannon/CannonKona architectural separation with dedicated flags, config validation, and test setup to fix CI failures based on feedback

* Set cannon-kona path in docker images
Add cannon-kona to set of default games.

* op-challenger: Fix tests.

* op-challenger: Add super-cannon-kona game type

Not yet supported as a trace type.

* op-challenger: Reduce duplicate code

---------

Co-authored-by: angel-ding-cb <[email protected]>
Co-authored-by: Leopold Joy <[email protected]>

* fix: version loop to handle tags with spaces (#17360)

* fix: bump validator version on develop (#17378)

This PR bumps the version for the StandardValidator on develop.
The version in the 4.1.0 proposal branch is 1.13.0 and this
version incldues changes that are not on the proposal branch, so
this version will be 1.14.0.

* fixed kona envs (#17370)

* op-acceptance-tests: upgrade tests with real-data (op-sepolia) (#17363)

* op-acceptance-tests: hfs ext package

* enable acceptance tests

* op-acceptance-tests: wait for LocalSafe to progress as well

* SerialT to ParallelT

* longer timeout

* correct runtime config print

* try run_all: true

* op-acceptance-tests: split sync_tester tests into multiple packages

* op-acceptance-tests: add Delta HF; use RollupConfig() instead of ChainConfig()

* enable check against UnsafeL2.Time

* use rollup types, and simplify tests

* extract WaitForNonZeroUnsafeTime

* better errors for syncTester session

* Get version of impls from the impl contracts themselves, reduce bytecode (#17377)

* docs: add interface inheritance guidelines and style examples to guide (#17339)

* docs: add interface inheritance guidelines to style guide

- Document why contracts must not inherit from their own interfaces
- Explain alignment issues with base contracts and compiler errors
- Add examples showing correct and incorrect patterns
- Include rationale for pseudo-constructor requirements

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update intro

* Fix outdated errors section

* Add examples to underscore prefixed args section

* Add examples for named vars

* Add examples for events

* Examples for immutables

* Examples for spacers

* Remove "trivial boolean with string" case as allowed.

* Fix example: errors go inside contract

* feat: add semgrep rule for event parameter formatting

Implement sol-style-event-param-fmt rule to enforce:
- Event parameters must use camelCase
- No underscore prefixes on event parameters
- All event parameters must be named

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Improve event params guidance and add a semgrep rule

* Undo adding immutable tests

It's a rabbit hole I don't want to go down rn

* Improve immutable examples

* Typo fix

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

---------

Co-authored-by: Claude <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* op-up: encode version information in binary (#17405)

* fix(op-acceptance-tests): wait for fund balance for persistent devnets (#17397)

* fix(op-acceptance-tests): wait for fund balance for persistent devnets

* fix(op-acceptance-tests): always wait for balance

* fix: remove unused variables from test file (#17400)

* op-conductor: p2p healthcheck fix and execution_p2p_healthcheck_api_type (#17294)

* op-conductor: p2p healthcheck fix and execution_p2p_healthcheck_api_type

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* nit

Signed-off-by: Yashvardhan Kukreja <[email protected]>

---------

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* circleci: enable OPM and Base mainnet op-node sync tests (nightly) (#17393)

* circleci: enable OPM op-node sync tests

* add base mainnet

* slack: notify on failure with mention in #notify-ci-failures

* use slack member id

* op-dispute-mon: Support cannon-kona games (#17380)

* ci: Add a stand alone check for solc warnings (#17403)

* ci: Add a stand alone check for solc warnings

* Use non-dev build to prevent compiler warnings

* op-up: update default version in install script (#17414)

* acceptance-tests.yaml: flashblocks-with-isthmus gate config (#17413)

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* feat(op-acceptance-tests): v3.2.1 (#17422)

Updates op-acceptor to v3.2.1, which adds an optional progress indicator

* feat(devstack): add user RPC method. fix kona config in sysgo (#17390)

* Revert "ci: Add a stand alone check for solc warnings (#17403)" (#17428)

This reverts commit 3f11e7f90488ace578c5ec27a937e9414421e309.

* afix slack in semgrep-scan (#17433)

* chore(op-acceptance-tests): ci timeout (#17438)

Temporarily increase the 'no_output' CircleCI timeout as there's an issue making the tests occasionally stall for a long time.

* op-node: Skip L1 genesis hash check if block is not available from the L1 (#17407)

* op-node: Skip L1 genesis hash check if block is not available from the L1

* op-node: Switch L1 genesis check to using MaybeAsNotFoundErr

Switch supervisor_client back to it's own isNotFound. MaybeAsNotFoundErr is specific to identifying blocks and headers that are not found, the supervisor client is looking for super root not found. That's an important distinction so we should use separate code.

* Fix lint

* Update test

* chore: bump op-geth to include new superchain registry configuration of arena-z-sepolia isthmus hardfork (#17437)

* refactor(test): improve L2CrossDomainMessenger test coverage and quality (#17415)

* refactor(test): improve L2CrossDomainMessenger test coverage and quality

- convert sendMessage test to fuzz test for broader parameter validation
- enhance constructor test with version and MESSAGE_VERSION assertions
- enhance initialize test with additional state validation
- add focused sendMessage test with full event verification
- all tests pass and maintain existing functionality

* fix: rename test function to follow naming convention

- Change testFuzz_sendMessage_validParams_succeeds to testFuzz_sendMessage_withValidTargetAndGasLimit_succeeds
- Addresses GitHub comment about generic 'validParams' reason
- Function name now follows [method]_[functionName]_[reason]_[status] pattern
- Updated comment to be more descriptive of test scenario

* fix: apply forge fmt to resolve contracts-bedrock-checks CI failure

- Fix import statement formatting (add spaces around braces)
- Fix function call formatting (add spaces around braces)
- Fix function parameter formatting for multi-line declarations
- Addresses contracts-bedrock-checks CI failure from previous commit

* fix: replace assert with assertGt for better test practices

- Replace assert(bytes(...).length > 0) with assertGt(bytes(...).length, 0)
- Use Forge's assertion functions instead of native Solidity asserts
- Addresses mds1's code review feedback

* feat: increase fuzz test gas limit bound from 5M to 30M

- Align with other cross-domain messaging tests in codebase
- CrossDomainMessenger.t.sol uses 30M, bridges use 10M, portal uses 50M
- 30M is only 0.70% of uint32.max and well within technical constraints
- Provides better fuzz coverage for realistic gas limit scenarios
- Addresses mds1's feedback about conservative 5M bound

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* feat: set up OPCM for U17 (#17406)

* feat: set up OPCM for U17

This PR removes U16 code from the OPCM and updates it to work for
U17. Various tests have been updated to support this, and the OPCM
has been improved so that it can be more easily utilized by
future maintainers.

* feat: get rid of old upgrade functions

* fix: semgrep errors

* fix: encodecall error

* fix: opcm check look at internal func

* fix: bump interop portal version

* fix: one more broken test

* fix: opcm graphite comment

* fix: go tests

* fix: superchain config test error

* fix: more test failures

* fix: more test failures

* fix: correct semgrep/event rules

* fix: pr review

* fix: compilation errors

* feat: contract changes to enable min-base-fee (#17330)

* min-base-fee solidity diffs

* Update packages/contracts-bedrock/src/L1/SystemConfig.sol

Co-authored-by: Matt Solomon <[email protected]>

* just pre-pr

* remove codegen bin

* update semver and remove some more diffs in systemconfig codegen

* revert bindings/systemconfig

* just pre-pr

---------

Co-authored-by: George Knee <[email protected]>
Co-authored-by: Matt Solomon <[email protected]>

* fix(op-deployer): EnsureDefaultCacheDir (#17411)

* justfile: add latest-versions recipe (#17399)

* justfile: add latest-versions recipe

* fix command failure masking

* print both stable and latest versions

* chore(cleanup): close #17194 (#17452)

* op-acceptance-tests: remove INITIAL_L2_BLOCK variable, and fetch latest block number from EL (#17453)

* op-deployer: read addresses onchain instead of from chainConfig (#17456)

* feat(op-acceptance-tests): op-acceptor v3.3.0 (#17467)

https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.3.0

* feat: add tests for min-base-fee (#17441)

* min-base-fee solidity diffs

* remove codegen bin

* update semver and remove some more diffs in systemconfig codegen

* revert bindings/systemconfig

* e2e test

* spike acceptance-test

* wip acceptance test

* add support for jovian mbf

* op-acceptance-test: min base fee (#14)

* add kurtosis files

* move dsl into test

* passing

* ensure block is progressing

* remove checkfordecrease func

* simulate txs

* nits + simplify

* base + jovian sysgo passes

* sysext passes

* nits + reduce bindings diff

* just wait for 1 block

* use zero addr, and swap test order

* add else clause to e2e test

* use high/med/zero mbfs

* e2e test configure mbf

* check activation block base fee is less than mbf

* wip setting diff mbfs

* claude fix

* build activation+1 block

* simulate some tx on diff med/high mbfs

* wip claude dont use extclient

* use 2gwei, 5gwei too high causes maxFeePerGas error

* sysgo and sysext pass for jovian

* dont default ptr(0) and first nit on action test

* remove user tx in actions

* acceptance-test no user tx + reduce diffs in actions

* kurtosis: run on jovian devnet (#15)

* wip

* pin teku version

* fix TestSystemConfigMarshaling

* fix attribute test + add comment in payload_util

* godoc: mbf in SystemConfig (#17481)

* fix: bug blocking op-deployer verify (#17478)

Fixes some bugs in op-deployer's verify command. Also fixes a few
issues with the contracts that causes the deployer to struggle
to properly verify things.

* feat(ci): parallelise go-tests jobs (#17468)

* feat(ci): go-tests now uses a fan-out.

These tests should now fan-out to multiple machines in CI, making the runs faster and more reliable.

* feat(make): simplified go-test-ci jobs

Reused a common target, as they were almost identical.

* op-deployer: update docker builds to install forge binary (#17304)

* op-deployer: include contracts build in 'just build' recipe

* modify build command to skip contracts build in ci

* install forge binary in op-deployer docker container

* lint and comment fixes

* remove Dockerfile.minimal

* always use docker bake to build and publish images

* op-program: Add hint for fast block hash lookup (#17449)

* chore(superchain-registry): bump version for addresses cleanup (#17404)

update to geth v1.101602.3-rc.1

* cleanup kt-devnets (#17455)

* cleanup kt-devnets

* ci: isthmus -> jovian

* update justfile

* dedupe

* activate jovian at genesis on jovian devnet

* op-acceptance-tests: Increase timeout for interop msg tests (#17492)

* op-acceptance-tests: Deflake TestPreNoBox by adjust Interop time to future (#17495)

* Revert "feat(op-acceptance-tests): op-acceptor v3.3.0 (#17467)" (#17502)

This reverts commit c813b04c9bd24a9b1088ec8a8e3a7598344633ff.

* op-devstack: op-sync-tester: Add configurable preset (#17491)

* op-devstack: op-sync-tester: Add sync tester config

* Use concrete orchestrator type

* refactor: introduce `IsFeature` toggles for Jovian (#17424)

* introduce IsMinBaseFee feature toggle

* add comment

* fix fn call (rename)

* fix test

* decouple features

* add operator fee fix toggle

* fix tests

* bump op-geth to mainline commit

* fix failing semgrep check (#17504)

* fix failing semgrep check

* add semgrep checks to pre-pr

* op-node: remove elSyncEnabled as it is a noop (#17425)

* remove hold job phase (#17506)

* op-sync-tester: Support EL Sync (#17516)

* op-sync-tester: Support EL Sync

* op-sync-tester: Rename to ELSyncActive

* proofs: Move proposer/challenger params on v2 contract (#17463)

* Make calldata length check overridable

* Rework calldata length check

* Make calldata length helpers more granular

* Update PDG to use CWIA for proposer and challenger

* Add a few more tests

* Cleanup - rework method name, comments

* Run just lint

* Fix test names

* Add some more tests around invalid FDG immutable args data

* Add tests around invalid immutable args when creating PDGv2

* Add some method documentation

* Regenerate snapshots, run semver-lock

* Simplify method name

* Fix notice natspec comments

* Clean up step tests

* Reorder auth check and call to super.initialize

* Add fuzz test to validate step() reverts for unauthorized actors

* Run semver-lock

* op-deployer: create generic forge.BytesScriptEncoder (#17524)

* op-deployer: create generic forge.BytesScriptEncoder

* add encoding support for arrays

* LivenessModule2 implementation (#17272)

* start

* DeployOwnership scripts update

* cleanup

* reset challangeStartTime when re-enabling the module

Co-authored-by: almanax-ai[bot] <174396398+almanax-ai[bot]@users.noreply.github.com>

* remove duplicated comment

* test cleanup

* fmt

* semverlock

* add livenessmodule2 to checkfrozenfiles

* address alcueca's feedback

* change ownershiptransfer logic

* pre-pr

* LivenessModule - Slightly simplified code (#17277)

* Slightly simplified code

---------

Co-authored-by: alcueca <[email protected]>

* address smartcontract's feedback

* alcueca's feedback

* smartcontract's feedback

* add extra checks suggested by alcueca

* fix clear error

* update snapshots

* conflicts

* name nitpicks and coverage at 100%

* fix tests

* remove interface extra lines

* fix event on test

* rename isChallenged function to getChallengePeriodEnd

* update snapshots

* update implementation from specs

* sentinel owner and interface fix

* DRYness comments

* move getter at the top

* update comment

* rename event

* add _assertModuleConfigured

* add _assertModuleEnabled

* assert module enable fixes

* _cancelChallenge internal function

* fix comments

* more comments

* split configure errors

* owner transfer invariant

* address comments

* address kelvin's feedback

* lint

* more comments

* alcueca's comments

---------

Co-authored-by: almanax-ai[bot] <174396398+almanax-ai[bot]@users.noreply.github.com>
Co-authored-by: Alberto Cuesta Cañada <[email protected]>
Co-authored-by: alcueca <[email protected]>

* op-acceptance-tests: move presets into tests, away from config.yaml (#17519)

* op-acceptance-tests: move network presets into tests, away from config.yaml

* op-acceptance-tests: simplify defaults for TestSyncTesterExtEL

* op-acceptance-tests: add stack.ExtNetworkConfig

* feat: add U16a report (#17538)

* feat: add U16a report

* Update docs/security-reviews/README.md

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* fix(op-deployer): forge verbose install (#17540)

* fix(op-deployer): forge verbose install

* fix(op-deployer): add ci docker build job

* opcm: Support cannon+kona games in addGameType (#17513)

* opcm: Support cannon+kona games in addGameType

* opcm: Update test name validation

* opcm: Remove unnecessary skips.

* opcm: Simplify test

* fix(op-deployer): remove forge version check (#17541)

* feat(op-deployer): cli based integration tests (#17511)

* refactor(test-validation): extract exclusions to TOML config and add tests (#17510)

* refactor(test-validation): extract exclusions to TOML config file

- move hardcoded exclusion lists from Go code to external TOML configuration
- add TOML parsing with structured ExclusionsConfig type
- implement dynamic exclusions loading with fallback path resolution

* test(test-validation): add test coverage for test-validation functions

- add tests for all previously untested functions in main.go
- organize test functions to match source file order

* op-deployer: simplify ReadImplementationAddresses.s.sol (#17542)

* op-deployer: simplify ReadImplementationAddresses.s.sol

* fix semgrep finding

* use getEIP1967Impl helper function

* fix comment

* tests: Skip Interop Acceptance Tests (#17555)

* Skip Interop Acceptance Tests

* exempt TestSuperRootWithdrawal

* fix: errant comment in OptimismPortal2 (#17482)

* fix: simplified code for SystemConfig code (#17539)

* chore(op-acceptance-tests): isthmus into base gate. (#17514)

As Isthmus is on Mainnet, we now move this gate into the 'base' gate which should work against all devnets.

* txmgr: fetch BlobBaseFee over RPC instead of computing from block header (#17566)

* txmgr: fetch BlobBaseFee over RPC instead of computing from block header

This simplifies the transaction manager, meaning it does not need to understand the chain config of L1 in order to estimate fees properly (which, from Fusaka, it will otherwise need to do because the formula for computing the blob base fee from the excess blob gas changes frequently with BPO forks).

* fix TestIncreaseGasPriceLimits

* fix TestTxMgrConfirmsBlobTxAtHigherGasPrice

* Update op-service/txmgr/txmgr.go

Co-authored-by: Sebastian Stammler <[email protected]>

---------

Co-authored-by: Sebastian Stammler <[email protected]>

* op-acceptance-tests: Ext Network EL Sync Test using Sync Tester (#17532)

* op-devstack: Expose L2EthExtendedClient for shim L2EL

* op-devstack: L2 CL Signaler Logic using admin API

* op-acceptance-test: op-acceptance-tests: EL Sync Test Config

* op-acceptance-tests: Sync Tester External Network HF tests: SyncMode

* op-sync-tester: Fix Post Isthmus WithdrawalRoots check

* op-devstack: Logging when L2 CL Signaling

* op-devstack: Explict Read Only Ext L2EL

* op-acceptance-tests: Proper preset for EL/CL Sync Testing

* rebase and cleanup

* ci: Sync Tester EL Sync test for real world

* op-acceptance-tests:  Proper genesis set for EL/CL Sync Testing

* fix test name

* deflake

* tame possible race

* op-acceptance-tests: Bump attempts for CL Sync testing (#17567)

* tools: add justfile command for updating op-geth (#17549)

* add just command for updating op-geth

* improve script

no dependence on jq
accept other git ref types

* txmgr: lock mutex when updating cachedTx map (#17570)

* feat(ops): add AI Contract Test Maintenance System v0.1.0 (#17560)

* feat(ops): add AI Contract Test Maintenance System v0.1.0

- Add new ai-eng directory for AI engineering projects
- Implement test ranking system with staleness-based scoring algorithm
- Add modular Python architecture for test file discovery and contract mapping
- Integrate with existing exclusion system from contracts-bedrock
- Add runbook.md document
- Add justfile integration for command-line execution
- Generate JSON output format for ranked test results
- Support git-based commit timestamp analysis for priority calculation
- Add CHANGELOG.md following

* fix(ops): clean up AI Contract Test Maintenance System files

- Remove generated ranking.json output file
- Remove CHANGELOG.md
- Fix formatting issues in runbook.md documentation

* refactor(ops): simplify AI Contract Test Maintenance System structure

- consolidate modular Python files into single test_ranker.py module
- trim runbook.md to essential info only (overview, usage, output)
- add .gitignore for Python projects and output files

* feat(ai-eng): add exclusion configuration for contract test maintenance

- Create exclusion.toml file with separate directory and file exclusions
- Update test_ranker.py to use centralized exclusion configuration
- Add tests without .sol counterparts to exclusion list
- Apply code formatting improvements to test_ranker.py

* all: update op-geth (based on go-ethereum v1.16.3) (#17547)

* update op-geth to: merge go-ethereum v1.16.3

https://github.com/ethereum-optimism/op-geth

* bump op-geth

* various fixes

* `params.HistoryServeWindow` changed

8192 -> 8191
https://github.com/ethereum/go-ethereum/pull/32127

* Updated op-geth to v1.101602.4-0.20250922085653-2f0528ba0ed5

* update op-geth

* update op-geth to v1.101603.0-rc.1

---------

Co-authored-by: geoknee <[email protected]>

* fix: update spearbit reviews (#17576)

* feat(ai-contracts-test): add prompt renderer component (#17578)

* feat(ai-contracts-test): add prompt renderer component

- implement render.py script for prompt generation with placeholder replacement
- add prompt/ directory with canonical prompt template (prompt.md)
- extend justfile with new commands: just render and just prompt (combined workflow)
- update runbook documentation with multi-step workflow instructions

* fix(semgrep): exclude prompt files from sol-safety-trycatch-eip150 rule

* perf: explictly set compiler runs to 0 to reduce profiles (#17572)

* feat: add safety checks for lockbox in setFeature (#17559)

* feat: add safety checks for lockbox in setFeature

* fix: better comment

* add coverage for MIPS64 back (#17409)

* chore(op-acceptance-tests): ci; remove kurtosis jobs. (#17581)

Kurtosis is being deprecated.

* feat(ai-contracts-test): add devin API integration (#17602)

* feat(ai-eng): reorganize components into a /component folder

- move test_ranker.py to components/tests_ranker/
- move prompt renderer to components/prompt-renderer/
- update justfile commands to use new component paths
- update documentation to reflect new directory structure

* feat(ai-contracts-test): add run ID system for test ranking and prompt generation

- add unique run ID generation using datetime format (YYYYMMDD_HHMMSS)
- update ranking output to include run_id field in JSON metadata
- change ranking filename format to {run_id}_ranking.json
- update prompt renderer to extract run_id from ranking filename
- change prompt filename format to {run_id}_prompt.md
- add automatic cleanup of old ranking and prompt files

* feat(ai-contracts-test): add devin api client with session logging

- add devin_client.py with full Devin API integration
- add JSONL logging system for session tracking and audit trail
- extend justfile with devin and ai-contracts-test commands
- update runbook documentation with Devin workflow and logging details
- add log.jsonl to gitignore for session logs

* github: Add git cliff config for release notes generation (#17594)

* chore(op-acceptance-tests): op-acceptor v3.3.1 (#17515)

Updates op-acceptor to [v3.3.1](https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.3.1)

* opcm: Zero out cannon-kona game types in migrate. (#17523)

* opcm: Zero out cannon-kona game types in migrate.

Only active if dev feature is enabled.

* fix opcm semver bump

* bump opcm validator semver

* revert semver changes to OPCMStandardValidator

---------

Co-authored-by: inphi <[email protected]>

* op-acceptance-tests: move sync-tester hardforks tests under one package (#17535)

* op-acceptance-tests: move all ext hfs tests to a single pkg

* op-acceptance-tests/hfs-ext: change Serial to Parallel

* op-acceptance_tests: consolidate hardforks_ext and sync_tester_hfs_ext

* op-service/httputil: move resp.Body.Close right after err check (#17611)

* feat: integrate creator pattern implementations in DeployImplementations.s.sol (#17329)

* feat: integration v2 implementations in DeployImplementations.s.sol + tests

* feat: add feature flag on and integrate deploy.s.sol

* feat: integrate deploy config and pass input struct values from config

* fix: configure a proposer in PDG

* fix: update the input struct for DeployImplementations.s.sol

* fix: implementation structs

* Update implementations_test.go

Co-authored-by: mbaxter <[email protected]>

* fix: use previous direct casting appraoch

* feat: integrate new bitmap feature

* fix: delete old bool

* fix: lint

* feat: add proposer to the config

* fix: implementation struct usage in sepolia test

* fix: add proposer to the struct for integration tests

* fix: fund the proposer and add it to the supercahin config

* fix: constructor args for pdgV2

* revert: remove proposer changes from op-chain-ops and op-deployer

Reverted changes to op-chain-ops/interopgen and op-deployer/pkg/deployer
directories back to the develop branch version as these changes are no
longer necessary for this PR.

* fix: remove proposer from deploy and deploy implementations

* fix: add back struct params

* fix: use casting for Impleemntations struct

* Update packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol

Co-authored-by: mbaxter <[email protected]>

* Update op-deployer/pkg/deployer/bootstrap/implementations.go

Co-authored-by: mbaxter <[email protected]>

* fix: remove modification of inputs ad revert if feature flag enabled

* Update packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol

Co-authored-by: Inphi <[email protected]>

* Update packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol

Co-authored-by: Inphi <[email protected]>

* fix: go back to v2 impl

* fix: missing import and simplify conditional for valid impl addresses

* fix: update check for correct nibble after kona consumed 0x010

* fix: remove unused import

* test: add assertions for constructor params

* test: add sensible fuzz input ranges

* feat: add reasonable constraints to deploys script and fuzz inputs

* fix: remove unused import

* refactor: add helper function and constant

* fix: move flags to their owner file

* fix: lint warning

* test: remove constraints on bitmap

* fix: remove input validation from deploy implemenations

* Revert "fix: remove input validation from deploy implemenations"

This reverts commit aa2557bf164854b9b917601fd32b8b542d3eef53.

* test: add splitdepth check

* test: update run with feature flag on and update asserts

* fix: add back superchain proxy admin and superchainConfigProxy

* fix: correct max game depth

* test: expand bounded values

* refactor: move asserts about v2 config params

---------

Co-authored-by: mbaxter <[email protected]>
Co-authored-by: Inphi <[email protected]>

* op-acceptance-tests: Disable `TestSyncTesterELSync` tests for flakiness (#17617)

* op-devstack: fix WaitForFinalization bug (#17618)

Previously, we waiting for the current finalized block to be finalized,
while the expected behavior is to wait for the current unsafe block
to be finalized. This is now documented as well.

* chore(op-acceptance-tests): op-acceptor v3.4.2 (#17623)

Updates op-acceptor to [v3.4.2](https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.4.2)

* op-node/rollup/clsync: test for popping the same element (#17608)

* refactor(test): improve Storage test coverage and quality (#17610)

* refactor(test): improve Storage test coverage and quality

- reorganize tests into function-specific contracts following codebase patterns
- convert all tests to proper fuzz tests with testFuzz_ naming
- organize test contracts to match source function declaration order
- enhance test documentation with proper @notice comments
- maintain existing comprehensive coverage for all 8 Storage library functions

* fix: address GitHub PR comments

- Move testFuzz_setGetBytes32Multi_succeeds to Storage_GetBytes32_Test
- Rename Storage_Unclassified_Test to Storage_Uncategorized_Test
- Add natspec comments for all fuzz parameters

* fix: address GitHub PR comments

- remove empty Storage_Uncategorized_Test contract
- rename testFuzz_setGetBytes32Multi_succeeds to testFuzz_getBytes32_multiSlot_succeeds for correct naming format

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* op-sync-tester: Retry block fetching when processing newPayload (#17624)

* op-sync-tester: Retry block fetching when processing newPayload

* op-acceptance-tests: Reenable TestSyncTesterELSync

* txmgr: allow blobs to be sent with fusaka-compatible cell proofs (sidecar version 1) by configuration (#17620)

* update batcher

* txmgr: log full tx hash to enable debugging

* cell proofs OFF by default

* thread configurable helper through to test code and add test TODOs

* wire up flag

* fix test

* op-e2e/actions: add EnableCellProofs config

* remove TODO

* use regular not atomic bool

* refactor MakeSidecar

* optimize creation of proofs slice

* feat: add rules for Diamond (#17640)

* contracts: Add new dispute game dev feature flags to bedrock test matrix (#17635)

* Integrate v2 dispute game feature flag into FeatureFlags setup util

* Add v2 flag to circleci matrix

* Add CANNON_KONA to test matrix

* fix: have acceptance job skip building contract tests (#17639)

Skips building contract tests in the acceptance job which reduces
the amount of memory used and decreases the chance of the job
being killed. Also makes it faster.

* op-e2e/actions: replicate geth txpool validation in `L1Miner.IncludeTx` (#17636)

* op-e2e/actions: replicate geth txpool validation in L1Miner.IncludeTx

* lint

* remove unecessary check

* op-node/rollup: remove ReceivedUnsafePayloadEvent event (#17530)

* op-node/rollup: remove ReceivedUnsafePayloadEvent event

* op-node/rollup: add lock around AddUnsafePayload

* op-deployer: setup forge callers for apply deploy scripts (#17637)

* op-deployer: prepare deploy scripts with forge invokers

* op-deployer: align test script with runWithBytes convention

* remove runWithBytes from DeployOPChain.s.sol

* op-e2e: Tweak EL Sync Test to check non genesis (#17440)

* fix(ai-contracts-test): handle 504 timeout, prevent duplicate work, prompt changes (#17616)

* fix(ai-contracts-test): handle 504 timeout and prevent duplicate work

- add 30s timeout and exponential backoff retry for Devin API server errors
- exclude files processed in last 7 days from ranking to avoid duplicate work
- add system version tracking to log entries
- minor cleanup: sort imports, remove shebangs and add invariants/ to exclusion list
- update runbook with latest changes

* fix(prompt): correct test naming, categorization, and assertion patterns

* update opcm.upgrade* natspec to explain the delegateCaller assumptions (#17644)

* update opcm.upgrade* natspec to explain the delegateCaller assumptions

* fix semver

* change semver

* feat: add ProtocolVersions to restrictions (#17651)

* feat: add ProtocolVersions to restrictions

* chore: snapshots

* sysgo: l1 geth subprocess support (#17619)

* refactor(test): standardize Unclassified to Uncategorized in test naming (#17650)

* refactor(test): standardize Unclassified to Uncategorized in test naming

- update test contract names from *_Unclassified_Test to *_Uncategorized_Test
- simplify checkTestMethodName function to only check for "Uncategorized"
- remove unused featureEnabledName parameter in checkTestMethodName

* Apply suggestion from @graphite-app[bot]

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Apply suggestion from @JosepBove

Co-authored-by: JosepBove <[email protected]>

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: JosepBove <[email protected]>

* feat(op-acceptance-tests): kurtosis nightly tests. (#17658)

* add valid semver check script and tests (#17641)

* add valid semver check script and tests

* upgrade MERC20F in opcm.upgrade

* cleanup

* cleanup

* change semver

* op-node: refactor EngineController (#17647)

* op-node/rollup: merge CLSync with EngineController

* op-node/rollup: migrate CLSync tests to EngineController

* op-node/rollup: use e.requestForkchoiceUpdate instead of emit

* op-node: renames

* op-node: lock unit test expectation

* op-node: better comments

* op-node: EngineController: Proper locking (#17648)

* op-node: EngineController: Proper locking

* op-node: EngineController: proper tryUpdateEngine sync

* stick to rwlock for simplicity

* Remove goroutine limit since race solved

* proper locking for ForceReset

* fix rebase

* fix locking

* op-deployer: ensure standard forge version matches mise (#17670)

* chore(op-acceptance-tests): ci; discord notifications. (#17672)

- Update Platforms notification from user 'stefano' to role 'protocol devx pod'
- Remove 'changwan' from Kurtosis notifications

* clean(op-acceptance-tests): ci; consolidate workflows. (#17673)

We no longer need a separate workfor for pre/post-merge to develop.

* all: update op-geth to "fusaka defence cherry pick" commit (#17661)

* updated op-geth to v1.101603.0-synctest.0.0.20250930110811-5eee1eab50e6

pairs with https://github.com/ethereum-optimism/op-geth/pull/690

* Updated op-geth to v1.101603.1-rc.1

* opcm: Add unit tests around DevFeatures (#17643)

* Add unit tests for DevFeatures.sol, fix logic

* Port changes and tests to go util

* Bump contract versions

* Run semver-lock

* Align test names with existing conventions

* ci: Add nightly heavy fuzz testing job (#17668)

* ci: Add nightly heavy fuzz testing job

- Add contracts-bedrock-heavy-fuzz-nightly job using ciheavy profile
- Configure for 20000 fuzz runs, 128 invariant runs, 512 depth
- Schedule via build_daily (nightly at 2 AM UTC)
- Add heavy_fuzz_dispatch parameter for manual testing
- Set 90m timeout for comprehensive fuzzing

* Update .circleci/config.yml

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* ci: Address PR feedback - remove unnecessary steps

- Remove 'Lint forge test names' step from nightly job
- Remove contracts-bedrock-build from workflow (job builds as needed)
- Update dependency to initialize directly

Addresses feedback from @mds1 and @aliersh

* ci: Restore duplicate generate-flaky-report section

Restores the duplicated generate-flaky-report job that was removed
during merge conflict resolution in b379b03. The duplicate section
was part of the develop branch changes and should not have been
removed as it was outside the scope of this PR.

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Ariel Diaz <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* op-acceptance-tests: introduce flake-shake system (#…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants