Skip to content

fix[dtl]: remove old stringification function #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2021
Merged

fix[dtl]: remove old stringification function #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
457771c
fix[dtl]: remove old stringification function
smartcontracts Jun 21, 2021
d666aec
chore: add changeset
smartcontracts Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-grapes-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/data-transport-layer': patch
---

Removes a function that was previously used for backwards compatibility but is no longer necessary
23 changes: 1 addition & 22 deletions packages/data-transport-layer/src/db/transport-db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,27 +387,6 @@ export class TransportDB {
startIndex: number,
endIndex: number
): Promise<TEntry[] | []> {
const entries = await this.db.range<TEntry>(
`${key}:index`,
startIndex,
endIndex
)
const results = []
for (const entry of entries) {
results.push(stringify(entry))
}
return results
}
}

const stringify = (entry) => {
if (entry === null || entry === undefined) {
return entry
}
if (entry.gasLimit) {
entry.gasLimit = BigNumber.from(entry.gasLimit).toString()
}
if (entry.decoded) {
entry.decoded.gasLimit = BigNumber.from(entry.decoded.gasLimit).toString()
return this.db.range<TEntry>(`${key}:index`, startIndex, endIndex)
}
}