This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Reset Context on invalid gaslimit #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Do we need reset in constructor too? Or was that only when we're using max uint256? |
smartcontracts
previously approved these changes
Mar 2, 2021
Collaborator
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM assuming not necessary in constructor
maurelian
pushed a commit
that referenced
this pull request
Mar 2, 2021
* add reset * add to constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was bricking the js-vm sometimes;
Contributing Agreement