Skip to content

Ci/fix bench #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Ci/fix bench #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc4e30f
.github/workflows: fix install of benchstat dependency
meowsbits Apr 7, 2022
2d17db8
core: fix benchmark panic
rjl493456442 Apr 7, 2022
e584559
core: un-skip failing bench tests
meowsbits Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/bench-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ jobs:

- name: Get dependencies
run: |
cd ..
go get golang.org/x/perf/cmd/...
cd -
go install golang.org/x/perf/cmd/benchstat@latest

- uses: actions/download-artifact@v2
name: Get go-ethereum artifact
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/bench-trie.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ jobs:

- name: Get dependencies
run: |
cd ..
go get golang.org/x/perf/cmd/...
cd -
go install golang.org/x/perf/cmd/benchstat@latest

- uses: actions/download-artifact@v2
name: Get go-ethereum artifact
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/bench-vm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,7 @@ jobs:

- name: Get dependencies
run: |
cd ..
go get golang.org/x/perf/cmd/...
cd -
go install golang.org/x/perf/cmd/benchstat@latest

- uses: actions/download-artifact@v2
name: Get go-ethereum artifact
Expand Down
4 changes: 1 addition & 3 deletions core/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,9 @@ func BenchmarkInsertChain_valueTx_100kB_diskdb(b *testing.B) {
benchInsertChain(b, true, genValueTx(100*1024))
}
func BenchmarkInsertChain_uncles_memdb(b *testing.B) {
b.Skip("pending upstream resolution of https://github.com/ethereum/go-ethereum/issues/24654")
benchInsertChain(b, false, genUncles)
}
func BenchmarkInsertChain_uncles_diskdb(b *testing.B) {
b.Skip("pending upstream resolution of https://github.com/ethereum/go-ethereum/issues/24654")
benchInsertChain(b, true, genUncles)
}
func BenchmarkInsertChain_ring200_memdb(b *testing.B) {
Expand Down Expand Up @@ -166,7 +164,7 @@ func genTxRing(naccounts int) func(int, *BlockGen) {

// genUncles generates blocks with two uncle headers.
func genUncles(i int, gen *BlockGen) {
if i >= 6 {
if i >= 7 {
b2 := gen.PrevBlock(i - 6).Header()
b2.Extra = []byte("foo")
gen.AddUncle(b2)
Expand Down