Skip to content

Conversation

cosmicKev
Copy link
Contributor

Description

Modifies the use of free to mdns_mem_free.
This allows the usage of custom allocators and therefore memory pools

Related

Testing

Changed the commit line to use mdns_memory_free instead of free and the custom allocation by rewriting mdns_mem_free starts working.


Checklist

Before submitting a Pull Request, please ensure the following:

  • [X ] 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • [X ] Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Fixes case where we create our own malloc/free allocators, therefore … Fixes case where we create our own malloc/free allocators, therefore … (IDFGH-16053) Jul 24, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 24, 2025
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! (and sorry for having missed this one)

We use conventional commits in this repo -- could you please amend your commit message to fix(mdns): Fix missing custom malloc/free case.
Or check the contribution guidelines and install the pre-commit hook.

… therefore we need to call mdns_mem_free and not free
@cosmicKev cosmicKev force-pushed the mdns-fix-custom-allocator branch from 9774ee9 to 63bf709 Compare July 24, 2025 11:22
@cosmicKev
Copy link
Contributor Author

Thank you.
All should be good now.

@david-cermak
Copy link
Collaborator

Thank you. All should be good now.

Thanks for the quick update! I'll wait for the CI to complete the tests and merge it!

@david-cermak david-cermak merged commit 8dbf0e4 into espressif:master Jul 25, 2025
95 checks passed
@david-cermak david-cermak mentioned this pull request Jul 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants