esp-serial: support automatic creation of esp serial device #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `class_create` to automatically create /dev/esps0 when driver is loaded. Eliminating the need to `mknod /dev/esps0`.
|
hello @t123yh , Thanks for time and efforts. |
| dev_t dev_num = dev_first + i; | ||
| devs[i].dev_index = i; | ||
| cdev_add(&devs[i].cdev, MKDEV(ESP_SERIAL_MAJOR, i), 1); | ||
| devs[i].dev = device_create(cl, NULL, dev_num, NULL, "esps%d", i); |
There was a problem hiding this comment.
Is this removed from OS automatically when driver unloads?
If not, it would be better to remove this manually before driver unloading.
There was a problem hiding this comment.
This is removed in line 269, device_destroy(cl, dev_num);
espressif-bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
- create and maintain serial driver /dev/esps0 from kernel module - removed serial creation and destroy from rpi_init.sh - closes PR #71 - closes PR #81 - closes PR #180 Co-authored-by: Yunhao Tian <[email protected]> Co-authored-by: ljgabc <[email protected]> Co-authored-by: David Rosen <[email protected]> Co-authored-by: Yogesh Mantri <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch use
class_createanddevice_createto automatically create/dev/esps0when driver is loaded, eliminating the need tomknod /dev/esps0.