Skip to content

Add default SPI pin definitions if not defined in pins_arduino.h #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2022
Merged

Add default SPI pin definitions if not defined in pins_arduino.h #7161

merged 6 commits into from
Sep 14, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Aug 22, 2022 •
edited
Loading

Description of Change

Added to some boards missing default pin declaration for SPI in pins_arduino.h + some I2C. Fixing SPI error in compilation.

Boards:
metro_esp-32
wt32-eth01

Tests scenarios

Variant wt32-eth01

Related links

Closes #7160

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 22, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Aug 22, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as draft August 22, 2022 11:12
@VojtechBartoska VojtechBartoska added this to the 2.0.5 milestone Aug 22, 2022
@me-no-dev
Copy link
Member

Why is this pr draft?

@P-R-O-C-H-Y
Copy link
Member Author

@me-no-dev Its still in progress. I cannot check if SCK etc. is defined, when it can be actually declared in pins_arduino.h
Need to think about that a bit maybe adding #define SPI_PINS_NOT_DECLARED to pins_arduino.h for boards, that have not these pins defined and checking that define in SPI.cpp.

@SuGlider SuGlider mentioned this pull request Aug 24, 2022
Closed
1 task
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review August 29, 2022 11:58
@VojtechBartoska
Copy link
Contributor

@SuGlider Can you please help with review? Thanks you

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Sep 14, 2022
Merged
@me-no-dev me-no-dev merged commit 8510734 into espressif:master Sep 14, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the SPI-default-definition branch April 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Libraries Issue is related to Library support.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

pins_arduino.h
4 participants
@P-R-O-C-H-Y @me-no-dev @VojtechBartoska @SuGlider