Skip to content

Conversation

william-ferguson-au
Copy link
Contributor

Fix for #3153

@me-no-dev me-no-dev merged commit 5bff89f into espressif:master Sep 29, 2019
@me-no-dev
Copy link
Member

thanks!

@william-ferguson-au
Copy link
Contributor Author

Any time.

@me-no-dev I would have solved this 3 days earlier, except I became derailed by either a subtle bug or my misunderstanding of the way that CString#c_str() is working. Would you mind jumping on https://www.esp32.com/viewtopic.php?f=19&t=12529 and explaining what I'm not understanding?

@ufanders
Copy link

Did this fix get merged into ESP32 Arduino Core library v1.0.4? I'm still seeing this problem.

@william-ferguson-au
Copy link
Contributor Author

william-ferguson-au commented Jan 16, 2020 via email

@ufanders
Copy link

Maybe so, but I had updated to v1.0.4 via the Arduino board manager and the issue persisted. I patched the code myself and it now works well.

@william-ferguson-au
Copy link
Contributor Author

william-ferguson-au commented Jan 16, 2020 via email

@william-ferguson-au william-ferguson-au deleted the issue-3153 branch March 27, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants