Skip to content

Tone limit 20KHz #7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2020
Merged

Tone limit 20KHz #7179

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5000ad
add comments for tone max frequency limit
Tech-TX Apr 1, 2020
a5eb7ea
add comments for tone max frequency limit
Tech-TX Apr 1, 2020
30df0ae
set Tone maximum frequency to 20KHz (was 5KHz)
Tech-TX Apr 1, 2020
11aee65
Merge branch 'master' into tone_limit_comments
Tech-TX Apr 3, 2020
397d314
dummy commit to kick Travis off
Tech-TX Apr 4, 2020
c32c1ba
Merge branch 'tone_limit_comments' of https://github.com/Tech-TX/Ardu…
Tech-TX Apr 4, 2020
d7bf500
dummy commit to kick Travis off
Tech-TX Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cores/esp8266/Tone.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ static void _startTone(uint8_t _pin, uint32_t high, uint32_t low, unsigned long

pinMode(_pin, OUTPUT);

high = std::max(high, (uint32_t)100);
low = std::max(low, (uint32_t)100);
high = std::max(high, (uint32_t)100); // 5KHz maximum tone for Arduino compatibility
low = std::max(low, (uint32_t)100); // (100us high + 100us low period = 5KHz)

if (startWaveform(_pin, high, low, (uint32_t) duration * 1000)) {
_toneMap |= 1 << _pin;
Expand Down