Expand BSSL stack #6819
Merged
Expand BSSL stack #6819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes esp8266#6811 which found an issue where connecting to scripts.google.com would *occasionally* cause a crash. On inspection, it was found that up to 5828 bytes of stack were used once in a while, so expand the stack to 5900 bytes to cover this case plus a little extra.
|
When connecting to mqtt.2030.ltsapis.goog also crashes occasionally, I'm getting a max usage of 6132. Expanding the stack to 6200 works for me. Edit: Not sure we should expand the stack, I'd be happy to open a PR. |
|
@DanielGarc , please check GIT master. We moved to 6200 bytes a while back: Arduino/cores/esp8266/StackThunk.cpp Line 43 in b02643e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6811 which found an issue where connecting to scripts.google.com
would occasionally cause a crash. On inspection, it was found that up
to 5828 bytes of stack were used once in a while, so expand the stack to
5900 bytes to cover this case plus a little extra.