Skip to content

MDNS Callback std:bind reference #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2019
Merged

MDNS Callback std:bind reference #6037

merged 2 commits into from
May 2, 2019

Conversation

hreintke
Copy link
Contributor

@hreintke hreintke commented May 2, 2019 •
edited by d-a-v
Loading

MDNS Callback setting needs std::bind parameter by reference instead of by value

@d-a-v d-a-v added this to the 2.5.1 milestone May 2, 2019
@hreintke
Copy link
Contributor Author

hreintke commented May 2, 2019

@d-a-v : This is not a fix for #5915.
It solves an issue reported by @LaborEtArs in gitter.

@devyte devyte merged commit 106d6f3 into esp8266:master May 2, 2019
@hreintke hreintke deleted the MDNS_Callback_Reference branch May 2, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@hreintke @d-a-v @devyte