LEAmDNS Fixes 1.2 #5641
Merged
LEAmDNS Fixes 1.2 #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2019 19:59
- Better separation of ESP wifi thread code from user thread code - Added a flag for 'update()'-less use (disabled by default) - The too fast updates for service queries are fixed - Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful) - The device should stay visible now even after the first TTL timeout - Improved service querying (queries five times now) - Fixed TTL (bug introduced with Fixes 1.0)
d-a-v
approved these changes
Jan 19, 2019
There was a problem hiding this comment.
We should run the https://developer.apple.com/download/more/?=Bonjour%20Conformance%20Test
devyte
approved these changes
Jan 20, 2019
|
Added a flag to avoid multiple initialization |
|
Flag free 'multi init stopper' now :-) |
Removed code remnant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of the cache flush bit from the whole query response (Fixes 1.1) was a bit too much... Removed the cache flush now from PTR TYPE and PTR NAME answers only.
Reenabled the 'Unicast Response' flag for probes