Skip to content

add 1 more IPAddress constructor #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2018
Merged

add 1 more IPAddress constructor #5551

merged 3 commits into from
Dec 26, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Dec 25, 2018

fix #5549

@jeffreykog jeffreykog mentioned this pull request Dec 26, 2018
Closed
6 tasks
@d-a-v d-a-v merged commit da7ffda into esp8266:master Dec 26, 2018
@d-a-v
Copy link
Collaborator Author

d-a-v commented Dec 26, 2018

Merging but this is not enough,
Another PR adding CI checking with IPv6 is being worked on (new mDNS currently does not compile).

@d-a-v d-a-v deleted the ipaddr6fix branch December 26, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devyte devyte devyte approved these changes

+1 more reviewer

@jeffreykog jeffreykog jeffreykog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build error while compiling with LWIP2 with IPv6

3 participants

@d-a-v @jeffreykog @devyte