Skip to content

Conversation

@acosinwork
Copy link
Contributor

The current version of ../generic/common.h does not allow to specify a different pin number A0 in the boards variants. This change will not affect the existing boards, but will allow to change A0 without duplicating the ../generic/common.h code.
It is needed here #3916
and may help here https://github.com/esp8266/Arduino/blob/master/variants/wifio/pins_arduino.h

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #3916 comment, it is useful and harmless.

@d-a-v d-a-v merged commit ab7e109 into esp8266:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants