Exposed sketch MD5 through HTTP headers #2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 27.86%@@ master #2236 diff @@
==========================================
Files 20 20
Lines 3653 3653
Methods 335 335
Messages 0 0
Branches 675 675
==========================================
Hits 1018 1018
Misses 2457 2457
Partials 178 178
|
|
Thanks for the pull request! Could you please fix indentation style to match nearby lines and update list of headers in documentation (https://github.com/esp8266/Arduino/tree/master/doc/ota_updates#advanced-updater-1)? |
|
Ahh, GitHub requires some getting used to... Anyways, I have updated the spacing and the docs; made the example web update service a little bit more shiny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested yesterday; this exposes the current sketch on device's MD5 hash through HTTP headers.