Skip to content

chore: add lint:unused script to run Knip #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 15, 2025

Prerequisites checklist

What is the purpose of this pull request?

Adds Knip to check for unused exports, unused dependencies, and missing dependencies

What changes did you make? (Give an overview)

  1. Adds Knip, similar to how it was done in:
  1. Adds in devDependencies that it noted are relied upon but don't exist
  2. Adds -y to the jsr launch to explicitly always run it without prompting

Is there anything you'd like reviewers to focus on?

Because this repo is a monorepo, its Knip config is a bit more complex than other repos'. I think I got the entry and project properties correct but I'm not positive.

@lumirlumir
Copy link
Member

Oops, it looks like there are quite a few merge conflicts. Whenever you have some time, could you take a look? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants