Skip to content

fix(ci): bump markdowncli-lint version #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

mureinik
Copy link

Bump the markdowncli-lint version to the newest available version to solve the runtime deprecation warning about f.R_OK.

Fixes #467

Bump the `markdowncli-lint` version to the newest available version to
solve the runtime deprecation warning about `f.R_OK`.

Fixes eslint-community#467
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They swapped over to esm too!

https://app.renovatebot.com/package-diff?name=markdownlint-cli&from=0.42.0&to=0.45.0

I am surprised that this can happen after running npm install -- I would have expected that without a lock file this is automatically kept updated 🤔

@scagood scagood changed the title fix(ci) bump markdowncli-lint version fix(ci): bump markdowncli-lint version Aug 1, 2025
@mureinik
Copy link
Author

mureinik commented Aug 1, 2025

I am surprised that this can happen after running npm install -- I would have expected that without a lock file this is automatically kept updated 🤔

@scagood It's a bit sneaky to notice, but since we're using a 0.x version of markdownlint-cli, ^0.42.0 means that npm install will take the latest 0.42.x version available. To quote node-semver's documentation:

[caret ranges] Allows changes that do not modify the left-most non-zero element in the [major, minor, patch] tuple. In other words, this allows patch and minor updates for versions 1.0.0 and above, patch updates for versions 0.X >=0.1.0, and no updates for versions 0.0.X.

@scagood
Copy link

scagood commented Aug 1, 2025

This has caught me out so many times! 😱

Thanks for explaining!

@scagood scagood requested a review from aladdin-add August 1, 2025 12:39
@aladdin-add aladdin-add merged commit 91a56d0 into eslint-community:master Aug 1, 2025
29 checks passed
@mureinik mureinik deleted the deprecation-warning branch August 1, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: deprecation warning when running lint:docs
3 participants