fix(no-missing-import): Support data imports #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scagood
reviewed
Jul 27, 2025
Good catch - I've amended the PR to address that, and added a test for it. |
Imported prefixed with 'data:' are not modules to be resolved, but the direct data that should be imported (e.g., JavaScript code, JSON or WASM). This PR adds support for such imports in the no-missing-import rule. Note: With this change, the rule doesn't attempt to parse the data being imported, it merely does not try to resolve it to a path (which would fail), and thus allows those imports in the user's code. Fixes eslint-community#464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported prefixed with
data:are not modules to be resolved, but the direct data that should be imported (e.g., JavaScript code, JSON or WASM).This PR adds support for such imports in the no-missing-import rule.
Note:
With this change, the rule doesn't attempt to parse the data being imported, it merely does not try to resolve it to a path (which would fail), and thus allows those imports in the user's code.
Fixes #464