test: change test runner to vitest #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the test runner from `mocha` + `nyc` to `vitest`. In order to import `vitest` the tests had to be in esm, so I checked out everything under the `tests` folder from eslint-community#516 (leaving the source as it was). I also moved the `eslint-rule-tester` out of the `tests/lib` folder and into its own `utils` folder. That way vitest didn't treat it as a test. Note: rather than using `vitest`'s preferred `v8` coverage reporter, I used the `istanbul` one, to ensure the coverages between old and new were the same. I did notice that when I tried the `v8` coverage reporter, the coverage numbers were much less. Something to consider as a follow-up change. The v8 reporter *should* be more accurate, so the coverage may not be as high as it seems. I'd recommend moving up to the `v8` reporter after the esm branch lands.
bmish
reviewed
Jun 19, 2025
bmish
reviewed
Jun 19, 2025
Merged
bmish
reviewed
Jun 19, 2025
bmish
reviewed
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the test runner from
mocha+nyctovitest.In order to import
vitestthe tests had to be in esm, so I checked out everything under thetestsfolder from #516 (leaving the source as it was).I also moved the
eslint-rule-testerout of thetests/libfolder and into its ownutilsfolder. That way vitest didn't treat it as a test.Note: rather than using
vitest's preferredv8coverage reporter, I used theistanbulone, to ensure the coverages between old and new were the same. I did notice that when I tried thev8coverage reporter, the coverage numbers were much less. Something to consider as a follow-up change. The v8 reporter should be more accurate, so the coverage may not be as high as it seems. I'd recommend moving up to thev8reporter after the esm branch lands.