debug_trace*: root gas should use tx.gasLimit
#8858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a semantic change to the `callTracer` as well as `flatCallTracer`. The value of field `gas` in the **first** call frame will change as follows: - It previously contained gas available after initial deductions (i.e. tx costs) - It will now contain the full tx gasLimit value Signed-off-by: jsvisa <[email protected]>
yperbasis
requested review from
AlexeyAkhunov,
canepat,
elee1766 and
lupin012
yperbasis
changed the title
debug_trace*: traces[0].gas should use tx.gasLimit
yperbasis
changed the title
debug_trace*: traces[0].gas should use tx.gasLimitdebug_trace*: root gas should use tx.gasLimit
AlexeyAkhunov
approved these changes
Dec 1, 2023
blxdyx
pushed a commit
to blxdyx/bsc-erigon
that referenced
this pull request
Jan 3, 2024
Cherry pick ethereum/go-ethereum#27029 --------- Signed-off-by: jsvisa <[email protected]> Co-authored-by: Delweng <[email protected]>
blxdyx
pushed a commit
to blxdyx/bsc-erigon
that referenced
this pull request
Jan 4, 2024
Cherry pick ethereum/go-ethereum#27029 --------- Signed-off-by: jsvisa <[email protected]> Co-authored-by: Delweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick ethereum/go-ethereum#27029