Revert "Docker pos fixup attempt1 (#5401)" #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43c848c.
yperbasis
requested review from
AlexeyAkhunov,
AskAlexSharov,
Giulio2002 and
mandrigin
|
@yperbasis then we need to rebuild the logic because w/o that fix, it gets into an infinite loop that it never can get out of. Reproduced on basically all our Erigon + others complained quite a bit. |
|
Throwing stuff away have some issues too, but at least at that point nodes can self-recover w/o the need to restart them. |
mandrigin
previously requested changes
Sep 18, 2022
Do you have more details on this infinite loop? I've made a couple of Merge-related improvements in the |
yperbasis
dismissed
mandrigin’s stale review
The infinite loop hasn't been reproduced with this branch (or docker_revert_5401)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 43c848c.
It's wasteful to throw away potentially useful incoming new blocks from CL.
Potentially fixes Issue #5412.