Added Engine Authentication [JWT] #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
reviewed
Feb 18, 2022
yperbasis
requested changes
Feb 18, 2022
There was a problem hiding this comment.
As discussed, authenticated Engine API should be on a separate port, 8551 (per the spec). So for the time being rpc daemon should run Engine API on two ports: 8550 (unauthenticated) & 8551 (authenticated). The rationale is to ease transitioning between Kiln v1 & v2. At some later date (but before the Merge happens in production) we'll drop the unauthenticated port.
enriavil1
approved these changes
Feb 21, 2022
yperbasis
approved these changes
Feb 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ethereum/execution-apis#167.