Skip to content

execution: remove BadHashes #17733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

execution: remove BadHashes #17733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320dcdc
execution: remove BadHashes
yperbasis Oct 31, 2025
6367302
rm ErrBlacklistedHash
yperbasis Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions execution/core/blocks.go
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions execution/stages/blockchain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ package stages_test
import (
"context"
"encoding/binary"
"errors"
"fmt"
"maps"
"math"
Expand Down Expand Up @@ -425,28 +424,6 @@ func testReorg(t *testing.T, first, second []int64, td int64) {
}
}

// Tests that the insertion functions detect banned hashes.
func TestBadBlockHashes(t *testing.T) { testBadHashes(t) }

func testBadHashes(t *testing.T) {
t.Parallel()
t.Skip("to support this error in Erigon")
// Create a pristine chain and database
m := newCanonical(t, 0)
var err error

// Create a chain, ban a hash and try to import
chain := makeBlockChain(current(m, nil), 3, m, 10)

core.BadHashes[chain.Headers[2].Hash()] = true
defer func() { delete(core.BadHashes, chain.Headers[2].Hash()) }()

err = m.InsertChain(chain)
if !errors.Is(err, core.ErrBlacklistedHash) {
t.Errorf("error mismatch: have: %v, want: %v", err, core.ErrBlacklistedHash)
}
}

// Tests that chain reorganisations handle transaction removals and reinsertions.
func TestChainTxReorgs(t *testing.T) {
if testing.Short() {
Expand Down
Loading