Do not apply milestone if tip is behind it #16890
Merged
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
reviewed
Aug 28, 2025
taratorio
reviewed
Aug 28, 2025
taratorio
approved these changes
Aug 28, 2025
taratorio
reviewed
Aug 28, 2025
taratorio
approved these changes
Aug 28, 2025
antonis19
changed the title
antonis19
added a commit
that referenced
this pull request
Sep 5, 2025
If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block. This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds. --------- Co-authored-by: antonis19 <[email protected]>
antonis19
added a commit
that referenced
this pull request
Sep 5, 2025
) cherry-pick of #16803 If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block. This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds. --------- Co-authored-by: antonis19 <[email protected]>
bloxster
pushed a commit
that referenced
this pull request
Sep 9, 2025
) cherry-pick of #16803 If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block. This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds. --------- Co-authored-by: antonis19 <[email protected]>
antonis19
added a commit
that referenced
this pull request
Sep 12, 2025
) cherry-pick of #16803 If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block. This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds. --------- Co-authored-by: antonis19 <[email protected]>
NazariiDenha
pushed a commit
that referenced
this pull request
Oct 24, 2025
) cherry-pick of #16803 If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block. This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds. --------- Co-authored-by: antonis19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tip is behind the milestone end, then this triggers an unwind to the previous verified milestone and download of blocks from previous verified milestone block until new milestone end block.
This is unnecessary since we can put the milestone back in the event queue, and it will be picked up later, and hopefully by that time the tip will be in sync with milestone. This is expected to reduce the number of unwinds.