workflows: Run run_migrations before running RPC tests
#16678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Aug 16, 2025
shohamc1
pushed a commit
that referenced
this pull request
Aug 20, 2025
Starting from #16678, we've tried using `integration run_migrations` within RPC Integration Tests CI workflows to handle creation of new tables automatically: it worked immediately for Ethereum, but failed for both Gnosis and Polygon. Some changes to `integration run_migrations` are necessary to make it work for them: - Gnosis: migrations must work also for `consensus` database, which is used there because pre-Merge consensus was AuRa. `ConsensusTables` used within `consensus` database already contained all `ChaindataTables`, so just running the migrations on the `consensus` database is sufficient. - Polygon: migrations must work also for both `heimdall` and `polygon-bridge` databases, which are used by internal Polygon components. In order to use exactly the same run migration procedure, we need to create all `ChaindataTables` also there. Of course, this is not ideal but IMO should be addressed as a separate issue (namely, refactoring and improvement of run migration procedure not to require the same tables in all databases).
canepat
pushed a commit
that referenced
this pull request
Sep 1, 2025
Making changes to MDBX tables does not result in failing RPC tests.
canepat
pushed a commit
that referenced
this pull request
Sep 1, 2025
Making changes to MDBX tables does not result in failing RPC tests.
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 2, 2025
…16935) Cherry-pick #16678 Cherry-pick #16711 Cherry-pick #16762 --------- Co-authored-by: Shoham Chakraborty <[email protected]>
yperbasis
pushed a commit
that referenced
this pull request
Sep 12, 2025
…16936) Cherry-pick #16678 Cherry-pick #16711 Cherry-pick #16762 --------- Co-authored-by: Shoham Chakraborty <[email protected]>
NazariiDenha
pushed a commit
that referenced
this pull request
Oct 24, 2025
Making changes to MDBX tables does not result in failing RPC tests.
NazariiDenha
pushed a commit
that referenced
this pull request
Oct 24, 2025
Starting from #16678, we've tried using `integration run_migrations` within RPC Integration Tests CI workflows to handle creation of new tables automatically: it worked immediately for Ethereum, but failed for both Gnosis and Polygon. Some changes to `integration run_migrations` are necessary to make it work for them: - Gnosis: migrations must work also for `consensus` database, which is used there because pre-Merge consensus was AuRa. `ConsensusTables` used within `consensus` database already contained all `ChaindataTables`, so just running the migrations on the `consensus` database is sufficient. - Polygon: migrations must work also for both `heimdall` and `polygon-bridge` databases, which are used by internal Polygon components. In order to use exactly the same run migration procedure, we need to create all `ChaindataTables` also there. Of course, this is not ideal but IMO should be addressed as a separate issue (namely, refactoring and improvement of run migration procedure not to require the same tables in all databases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making changes to MDBX tables does not result in failing RPC tests.