-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Move polygon/bor/valset to polygon/heimdall and flatten
#16556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the validator set module by moving types and functions from polygon/bor/valset to polygon/heimdall and flattening the package structure. The refactoring consolidates related Polygon/Bor validator functionality under a single package.
- Moves
Validator,ValidatorSet, and related types frompolygon/bor/valsettopolygon/heimdall - Updates import statements across the codebase to reference the new location
- Removes the now-empty
polygon/bor/valsetpackage files
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rpc/jsonrpc/bor_helper.go | Updates import and type references from valset to heimdall package |
| rpc/jsonrpc/bor_api_impl.go | Updates import and return type annotations for validator functions |
| rpc/jsonrpc/bor_api.go | Updates interface definitions to use heimdall validator types |
| polygon/sync/block_producers_reader.go | Updates interface to reference heimdall.ValidatorSet |
| polygon/heimdall/validator_set.go | Consolidates validator types and functions from valset package |
| polygon/heimdall/span_test.go | Updates test code to use heimdall validator types directly |
| polygon/heimdall/span_block_producers_tracker.go | Updates function calls and imports for consolidated validator functionality |
| polygon/heimdall/span_block_producer_selection.go | Updates type references and removes unused imports |
| polygon/heimdall/span.go | Updates validator type references in span data structures |
| polygon/heimdall/service.go | Updates service interface to return heimdall.ValidatorSet |
| polygon/heimdall/server.go | Updates gRPC server to work with heimdall validator types |
| polygon/heimdall/reader.go | Updates reader implementations for new validator type locations |
| polygon/heimdall/client_idle.go | Updates idle client to use heimdall validator types |
| polygon/bor/valset/validator.go | Removes file - code moved to heimdall package |
| polygon/bor/valset/errors.go | Removes file - code moved to heimdall package |
| polygon/bor/spanner_test_validators.go | Updates test validator definitions to use heimdall types |
| polygon/bor/spanner_mock.go | Removes mock methods that are no longer needed |
| polygon/bor/spanner.go | Updates spanner to use heimdall validator types |
| polygon/bor/bor_test.go | Updates test code to use heimdall validator types and functions |
| polygon/bor/bor_internal_test.go | Updates mock interface to return heimdall.ValidatorSet |
| polygon/bor/bor.go | Updates main Bor implementation to use heimdall validator types |
| eth/backend.go | Updates import to use heimdall error types |
| cmd/rpcdaemon/cli/config.go | Updates interface to use heimdall.ValidatorSet |
| cmd/devnet/services/polygon/heimdall.go | Updates devnet service to use heimdall validator types |
Co-authored-by: antonis19 <[email protected]>
cherry-pick to release/3.1 of the following PRs: #16404 #16409 #16411 #16433 #16458 #16464 #16520 #16556 --------- Co-authored-by: antonis19 <[email protected]> Co-authored-by: Mark Holt <[email protected]>
Co-authored-by: antonis19 <[email protected]>
No description provided.