refactor: use the built-in max/min to simplify the code #16213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pingshuijie <[email protected]>
AskAlexSharov
approved these changes
Jul 25, 2025
Contributor
Author
|
Thank you for your review and approval. |
NazariiDenha
pushed a commit
that referenced
this pull request
Oct 24, 2025
use the built-in max/min to simplify the code Signed-off-by: pingshuijie <[email protected]> Co-authored-by: yperbasis <[email protected]>
This was referenced Oct 27, 2025
taratorio
pushed a commit
that referenced
this pull request
Oct 27, 2025
In Go 1.21, the standard library includes built-in [max/min](https://pkg.go.dev/[email protected]#max) function, which can greatly simplify the code. Inspired by #16213 and replace more. Signed-off-by: zhetaicheleba <[email protected]>
yperbasis
pushed a commit
that referenced
this pull request
Oct 27, 2025
In Go 1.21, the standard library includes built-in [max/min](https://pkg.go.dev/[email protected]#max) function, which can greatly simplify the code. Inspired by #16213 and replace more. Signed-off-by: zhetaicheleba <[email protected]>
yperbasis
pushed a commit
that referenced
this pull request
Oct 27, 2025
In Go 1.21, the standard library includes built-in [max/min](https://pkg.go.dev/[email protected]#max) function, which can greatly simplify the code. Inspired by #16213 and replace all. Signed-off-by: zhetaicheleba <[email protected]>
AskAlexSharov
pushed a commit
that referenced
this pull request
Oct 28, 2025
In Go 1.21, the standard library includes built-in [max/min](https://pkg.go.dev/[email protected]#max) function, which can greatly simplify the code. Inspired by #16213 and replace more. Signed-off-by: zhetaicheleba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the built-in max/min to simplify the code