Feat add request id extension settings in ctp #7421
+273
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7421 +/- ##
==========================================
+ Coverage 72.28% 72.34% +0.06%
==========================================
Files 231 231
Lines 33999 34025 +26
==========================================
+ Hits 24576 24617 +41
+ Misses 7652 7635 -17
- Partials 1771 1773 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: i.makarychev <[email protected]> Signed-off-by: i.makarychev <[email protected]>
Inode1
force-pushed
the
feat-request-id-extension
branch
from
c163766 to
c5b435d
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently, Envoy Gateway configures the HTTP listener with UuidRequestIdConfig and pack_trace_reason set to true by default. This changes the generated x-request-id format from UUID v8 to UUID v4.
Add options to settings requestidextension in CTP
Which issue(s) this PR fixes:
Fixes #6750
Release Notes: Yes/No