fix error when updating invalid gateway status #7415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
commented
Nov 3, 2025
| - attachedRoutes: 0 | ||
| conditions: null | ||
| name: http | ||
| supportedKinds: null |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7415 +/- ##
=======================================
Coverage 72.31% 72.32%
=======================================
Files 231 231
Lines 33970 33970
=======================================
+ Hits 24566 24569 +3
+ Misses 7634 7632 -2
+ Partials 1770 1769 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
previously approved these changes
Nov 3, 2025
arkodg
reviewed
Nov 3, 2025
| } | ||
|
|
||
| // we cannot do this early, otherwise there's an error when updating status. | ||
| gCtx.ResetListeners(resources, envoyproxyMap) |
There was a problem hiding this comment.
due to the logic change, can we delete
gateway/internal/gatewayapi/contexts.go
Line 48 in 9935819
There was a problem hiding this comment.
if required by L398 to make sure envoyproxy is not alway nil.
There was a problem hiding this comment.
Sorry, I read wrong line, deleted.
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
arkodg
approved these changes
Nov 4, 2025
|
/retest |
kkk777-7
approved these changes
Nov 4, 2025
arkodg
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #7009
fixes: #7414