docs: add reference to gateway-api and sort index #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 63.34% 63.10% -0.25%
==========================================
Files 47 47
Lines 5754 5754
==========================================
- Hits 3645 3631 -14
- Misses 1881 1893 +12
- Partials 228 230 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: bitliu <[email protected]>
danehans
reviewed
Oct 21, 2022
docs/index.rst
Outdated
| This project is under active development. Many, many features are not | ||
| complete. We would love for you to :doc:`get involved<get_involved>`. | ||
|
|
||
| This project is now listed in official |
Contributor
danehans
reviewed
Oct 21, 2022
docs/index.rst
Outdated
| complete. We would love for you to :doc:`get involved<get_involved>`. | ||
|
|
||
| This project is now listed in official | ||
| `Gateway API implementations <https://gateway-api.sigs.k8s.io/implementations/#envoy-gateway>`_ . |
Contributor
There was a problem hiding this comment.
s/implementations/implementation/
Signed-off-by: bitliu <[email protected]>
Contributor
|
imho if we we are linking back to the Gateway API docs, there should be a good reason why it matters to the user
|
Contributor
|
@Xunzhuo do you mind resolving the review feedback or closing this PR? |
Member
Author
|
Yes @danehans, I think we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #624
Signed-off-by: bitliu [email protected]