Support Gauge in access_loggers.stats #42226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuyang Tao <[email protected]>
TAOXUY
requested review from
ggreenway,
kyessenov and
wbpcode
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
TAOXUY
changed the title
Contributor
Author
mattklein123
requested changes
Nov 27, 2025
Comment on lines
+117
to
+118
| // A fixed value to add to this counter. | ||
| // One of ``value_format`` or ``value_fixed`` must be configured. |
Member
There was a problem hiding this comment.
This comment needs to be updated for how it relates to the gauge operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: add gauge support in access_loggers.stats
Risk Level:low
Testing:both unit test and integration test are added
Docs Changes: updated in the protobuf comments
Release Notes: updated
Platform Specific Features:no