Skip to content

Conversation

@sergiitk
Copy link
Contributor

#30834 was merged before cncf/xds#74, so @com_github_cncf_xds point to commit on the PR branch, and not main.

This PR fixes it by pointing to the commit merged to main.


Commit Message:

bazel: fix incorrect version of `@com_github_cncf_xds`

Additional Description:

https://github.com/envoyproxy/envoy/pull/30834 was merged before
https://github.com/cncf/xds/pull/74, so `@com_github_cncf_xds` point
to commit on the PR branch, and not `main`.

This PR fixes it by pointing to the commit merged to `main`.

Risk Level: low
Testing: do_ci.sh
Docs Changes: no
Release Notes: no

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 16, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #30930 was opened by sergiitk.

see: more, trace.

@sergiitk
Copy link
Contributor Author

FYI @yanavlasov

@yanavlasov yanavlasov enabled auto-merge (squash) November 16, 2023 19:22
@sergiitk
Copy link
Contributor Author

@moderation could you please merge this one?

@yanavlasov yanavlasov merged commit ab976b1 into envoyproxy:main Nov 20, 2023
@sergiitk sergiitk deleted the cncf-xds-canonical-cel-version branch November 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants