This repository was archived by the owner on Feb 17, 2022. It is now read-only.
Possible stdio_seek fix #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal to stdio SEEK_*
|
Hmm, looks like at one point SDL just used the stdio defines, and that changed back in 2006. (6c3f928#diff-fa81b9a4698473870db0819ad83fe96d). This looks like the right thing to do, but since SDL hasn't had a problem with this on any other platform, it looks like those values are pretty standard... |
|
Interesting, thanks @Daft-Freak! I'm trying to get wasi to change its constants to match everything else, WebAssembly/WASI#106 if that works then we won't need this. |
|
Looks like upstream fixed this: spurious/SDL-mirror@f8e45d4 |
|
Oh great! Meanwhile wasi agreed to update those constants anyhow. So looks like good results all around and no need for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code assumes
RW_SEEK_*is identical to stdioSEEK_*. AFAICT those values are not standardized, so they are arbitrary.Am I missing something, or is this a real bugfix?
This fixes some tests in emscripten-core/emscripten#9555 where we are moving to the wasi constants for
SEEK_*and for some reason those are different than the common values used in musl and I guess most linuxes etc.