Skip to content

Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Worklets enabled #25364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2025
Merged

Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Worklets enabled #25364

merged 5 commits into from
Sep 29, 2025

Conversation

@juj
Copy link
Collaborator

@juj juj commented Sep 23, 2025

Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Worklets enabled, for a code size saving of 7 bytes.

Before, Closure would emit:

m = "em-ww" == globalThis.name,
n = !!globalThis.AudioWorkletGlobalScope,
n && (m = !0);

Afterwards, it emits

n = !!globalThis.AudioWorkletGlobalScope,
m = "em-ww" == globalThis.name || n,

@juj
Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Wo…
8b3f800 
…rklets enabled, for a code size saving of 7 bytes.
sbc100
sbc100 reviewed Sep 23, 2025
View reviewed changes
@juj juj enabled auto-merge (squash) September 25, 2025 20:25
@juj juj merged commit b45fcac into emscripten-core:main Sep 29, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juj @sbc100