Skip to content

Remove support for windows 7 from .bat file launchers #24913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 12, 2025

This removed that handling of EM_WORKAROUND_WIN7_BAD_ERRORLEVEL_BUG which is workaround for a windows 7 issue.

This removed that handling of `EM_WORKAROUND_WIN7_BAD_ERRORLEVEL_BUG`
which is workaround for a windows 7 issue.
@sbc100 sbc100 requested a review from juj August 12, 2025 17:32
@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 12, 2025

@juj, can you confirm that you no longer need Windows 7 support?

@juj
Copy link
Collaborator

juj commented Aug 12, 2025

We no longer need Windows 7 support (we only support Windows 10 + 11), but I do not trust Windows+Python enough to drop EM_WORKAROUND_WIN7_BAD_ERRORLEVEL_BUG like this.

While we triaged the issue to be a Windows 7 specific issue back then, I really want to see in action that we don't get this issue in latest code if we drop this workaround.

So instead what I propose we'll do is that I'll drop this workaround env. var. from being used in production in next Emscripten version that we update Unity to, and if that goes good and we get no user bugs, then we can remove these from Emscripten altogether. So.. ask again in a year or two? :|

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 12, 2025

OK, sounds good.

So IIUC, you are currently setting this environment variable in the SDK that you ship?

@juj
Copy link
Collaborator

juj commented Aug 12, 2025

So IIUC, you are currently setting this environment variable in the SDK that you ship?

Yeah that's correct. Whenever we invoke Emscripten, we set the env. var.

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 12, 2025

OK, lets revisit once you have shipped a version with it removed for N months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants