Fix for bad byte offset locations when bytes precede '%PDF-'. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when bytes precede '%PDF-'.
Author
|
ScanNextToken() will usually crash if it finds itself inside of a stream due to unexpected characters. Currently, my added function IsValidXref() uses ScanNextToken() to determine if the next token is an 'xref' token. This is used to determine if a fix needs to be made. However, if startxref is wrong, the _lexer.Position could be inside of a stream which will more than likely cause an exception. |
mlaukala
force-pushed
the
xref_offset
branch
from
4cb436e to
3c346c3
Compare
mlaukala
force-pushed
the
xref_offset
branch
from
1614146 to
833993f
Compare
mlaukala
force-pushed
the
xref_offset
branch
from
833993f to
2a6ad48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes invalid byte offset values for startxref and xref object offsets when bytes precede '%PDF-'.