Removed .defaultProps support
#3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c7f02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Andarist
commented
Dec 9, 2024
Comment on lines
+20
to
+31
| afterEach(() => { | ||
| let cache | ||
| function GetCache() { | ||
| cache = __unsafe_useEmotionCache() | ||
| return null | ||
| } | ||
| enzyme.shallow(<GetCache />) | ||
|
|
||
| cache.registered = {} | ||
| cache.inserted = {} | ||
| cache.sheet.flush() | ||
| }) |
Member
Author
There was a problem hiding this comment.
this is a quick hack, I don't quite care about this - we'll be removing Enzyme's support (and thus this file) soon
emmatown
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3184
Technically this breaks
.defualtPropson classes too and those are still supported by React 19. I don't quite think it's worth supporting it though and we can't easily rely on React doing the merging for us because we always output function components. So we'd have to either conditionally create wrapping classes OR do the "defaulting" ourselves