Skip to content

Conversation

shiaky
Copy link
Contributor

@shiaky shiaky commented Feb 15, 2020

Thank you for creating this package. I love using it. Currently I was confronted with a JSON RPC library on server side that is sending Websocket messages of the type BINARY. Therefore I had to adapt jsonrpc-websocket a little bit.

I would be happy if the change would make it in the pip package. Unfortunately I was not able to figure out how to write a testcase for this. Maybe you can help me out.

Cheers

@emlove
Copy link
Owner

emlove commented Feb 17, 2020

Hi, thanks for the PR!

This makes sense to me. And honestly the tests are a complete mess, but this library changes so infrequently I haven't bothered updating them.

I've pushed up a little bit of refactoring to this branch to clean it up now that we're parsing requests from different websocket message types. Can you confirm this still works with your server?

@shiaky
Copy link
Contributor Author

shiaky commented Feb 17, 2020

Hi Emily,
thank you a lot for refactoring the code and adding tests. It works perfect for me. I can confirm that it works with tinyrpc used in ryu wsgi websocket library.

Thank you again for creating this package.

@emlove emlove merged commit a7705db into emlove:master Feb 17, 2020
@emlove
Copy link
Owner

emlove commented Feb 17, 2020

Thanks for your contribution! 🦄

Pushed up version 1.1.0 to pypi with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants