Skip to content

Enable ember-cli project generation #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable ember-cli project generation #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c6179
enable ember-cli project generation
mansona Nov 10, 2023
b2224d3
add spaces to rev-index json
mansona Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions generate-local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function semverVersion(value) {
program
.addOption(
new Option('-p, --project <project>', 'the project that you want to run this for')
.choices(['ember', 'ember-data'])
.choices(['ember', 'ember-data', 'ember-cli'])
.makeOptionMandatory(),
)
.requiredOption('-v, --version <version>', 'project version', semverVersion);
Expand Down Expand Up @@ -59,6 +59,7 @@ try {

let emberProjectPath = path.join('../', 'ember.js');
let emberDataProjectPath = path.join('../', 'data');
let emberCliProjectPath = path.join('../', 'ember-cli');

let checkIfProjectDirExists = dirPath => {
if (!existsSync(dirPath)) {
Expand All @@ -69,14 +70,14 @@ let checkIfProjectDirExists = dirPath => {
let buildDocs = async projDirPath => {
checkIfProjectDirExists(projDirPath);

if (project === 'ember') {
await runCmd('volta', projDirPath, ['run', 'yarn']);
} else {
if (project === 'ember-data') {
await runCmd('corepack', projDirPath, ['pnpm', 'install']);
} else {
await runCmd('volta', projDirPath, ['run', 'yarn']);
}

await runCmd(
project === 'ember' ? 'volta run yarn docs' : 'corepack pnpm run build:docs',
project === 'ember-data' ? 'corepack pnpm run build:docs' : 'volta run yarn docs',
projDirPath,
);

Expand All @@ -86,16 +87,20 @@ let buildDocs = async projDirPath => {
removeSync(projYuiDocFile);
removeSync(`${docsPath}/json-docs/${project}/${version}`);

const yuiDocFile = path.join(
projDirPath,
project === 'ember' ? 'docs/data.json' : 'packages/-ember-data/dist/docs/data.json',
);
const paths = {
ember: 'docs/data.json',
'ember-cli': 'docs/build/data.json',
'ember-data': 'packages/-ember-data/dist/docs/data.json',
};

const yuiDocFile = path.join(projDirPath, paths[project]);
copyFileSync(yuiDocFile, projYuiDocFile);
};

let dirMap = {
ember: emberProjectPath,
'ember-data': emberDataProjectPath,
'ember-cli': emberCliProjectPath,
};

await buildDocs(dirMap[project]);
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function semverVersion(value) {
program
.addOption(
new Option('-p, --projects <project...>', 'the projects that you want to run this for')
.choices(['ember', 'ember-data'])
.choices(['ember', 'ember-data', 'ember-cli'])
.makeOptionMandatory(),
)
.addOption(
Expand Down
2 changes: 1 addition & 1 deletion lib/rev-docs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function revProjVersionFiles(project, ver) {
);
});

fs.writeJsonSync(projVerRevFile, projVerRevContent);
fs.writeJsonSync(projVerRevFile, projVerRevContent, { spaces: 2 });
opProgress.succeed('Revving done!');
}

Expand Down