Skip to content

chore: remove node-sass #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove node-sass #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const EmberApp = require('ember-cli/lib/broccoli/ember-app');
const envIsProduction = process.env.EMBER_ENV === 'production';
const premberUrls = require('./prember-urls');
const nodeSass = require('node-sass');

Check failure on line 6 in ember-cli-build.js

View workflow job for this annotation

GitHub Actions / Lint files 

"node-sass" is not found

Check failure on line 6 in ember-cli-build.js

View workflow job for this annotation

GitHub Actions / Lint files 

'nodeSass' is assigned a value but never used

module.exports = function (defaults) {
let app = new EmberApp(defaults, {
Expand All @@ -24,7 +24,6 @@
generateAssetMap: true,
},
sassOptions: {
implementation: nodeSass,
sourceMapEmbed: !envIsProduction,
includePaths: [
'app/styles',
Expand Down
21 changes: 12 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
"algoliasearch": "^4.20.0",
"babel-eslint": "^10.1.0",
"bootstrap": "^4.6.2",
"bourbon": "5.1.0",
"bourbon-neat": "^1.9.1",
"bourbon": "7.3.0",
"bourbon-neat": "^4.0.0",
"broccoli-asset-rev": "^3.0.0",
"broccoli-funnel": "^2.0.1",
"ember-a11y-testing": "^5.2.1",
Expand All @@ -82,7 +82,7 @@
"ember-cli-htmlbars": "^6.1.1",
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-meta-tags": "^7.0.0",
"ember-cli-sass": "^10.0.1",
"ember-cli-sass": "^11.0.1",
"ember-cli-showdown": "^9.0.1",
"ember-cli-terser": "^4.0.2",
"ember-composable-helpers": "^3.1.1",
Expand All @@ -104,7 +104,7 @@
"ember-showdown-shiki": "^1.2.1",
"ember-sinon": "^4.1.1",
"ember-source": "~3.28.8",
"ember-styleguide": "^3.3.0",
"ember-styleguide": "^11.0.3",
"ember-svg-jar": "^2.4.2",
"ember-template-lint": "^3.15.0",
"ember-test-selectors": "^6.0.0",
Expand All @@ -130,14 +130,14 @@
"lodash.uniq": "^4.5.0",
"lodash.values": "^4.3.0",
"minimist": "^1.2.6",
"node-sass": "^9.0.0",
"normalize.css": "^8.0.1",
"npm-run-all": "^4.1.5",
"prember": "^2.1.0",
"prettier": "^2.5.1",
"qunit": "^2.17.2",
"qunit-dom": "^1.6.0",
"sanitize-html": "^2.3.2",
"sass": "^1.86.0",
"semver": "^7.5.4",
"semver-compare": "^1.0.0",
"spawndamnit": "2.0.0",
Expand All @@ -146,8 +146,8 @@
"webpack": "^5.90.0"
},
"engines": {
"node": "16.* || 18.* || 20.*",
"npm": "7 || 8 || >= 9"
"node": "16.* || 18.* || 20.* || >= 22",
"npm": "7 || 8 || 9 || >= 10"
},
"cacheDirectories": [
"node_modules"
Expand All @@ -168,9 +168,12 @@
},
"pnpm": {
"overrides": {
"node-sass": "^9.0.0",
"ember-truth-helpers": "^4.0.0"
}
},
"packageManager": "[email protected]"
"packageManager": "[email protected]",
"volta": {
"node": "23.10.0",
"pnpm": "10.6.5"
}
}
Loading
Loading