Skip to content

Update to [email protected] #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2020
Merged

Update to [email protected] #70

merged 6 commits into from
Oct 23, 2020

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 16, 2020

No description provided.

@bobisjan bobisjan mentioned this pull request Oct 20, 2020
Closed
@bobisjan
Copy link
Contributor

bobisjan commented Oct 22, 2020

I've tried this locally, and it looks that there is difference between [email protected] and [email protected]:

When I moved the result finalisation into finally block and removed this return statement, then tests passed.

@bobisjan bobisjan mentioned this pull request Oct 23, 2020
Merged
@rwjblue
Copy link
Member Author

rwjblue commented Oct 23, 2020

Thank you @bobisjan!

Restart resilient mode behavior
f50f3b1 
I find this behavior to be _very odd_, but it matches what we have under
test. Specifically, it seems bizarre to call `next` and then do
_anything_ with the response still, calling `next` signifies "I'm done
here"!!?!?!!
@rwjblue rwjblue merged commit d7a504c into ember-fastboot:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rwjblue @bobisjan